Update some more tests relying on timeouts #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcollina this should help further.
However, I don't like the fix here because as a user of
httpClient
I would expect forclient.destroy()
to work regardless of when it is called. In the current implementation,client.destroy()
will not work as expected if invoked synchronously in a timeout handler. It does not clear the retry mechanism of thehttpClient
.I think the "right" fix consists in using a different version of
retimer
that allows to reset the timer after it has been triggered. This way there is no need to change the instance of retimer within thehttpClient
.Cf.
autocannon/lib/httpClient.js
Line 73 in f8b598e