Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some more tests relying on timeouts #341

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Update some more tests relying on timeouts #341

merged 4 commits into from
Mar 2, 2021

Commits on Mar 1, 2021

  1. Remove unnecessary timeout check in httpClient delay 

    In addition it's probably better to use a t.setTimeout(..) than assertion for a timeout because it will come with a clear and informative error message.
    @nherment
    nherment committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    0405f14 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Update a couple of tests that don't do well in low CPU env. 

    Avoid relying on node being able to execute its setTimeouts within a reasonable time to account for the low performance VMs of the tests environments.
    @nherment
    nherment committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0bab9ed View commit details
    Browse the repository at this point in the history

  2. add empty line for readability in a test

    @nherment
    nherment committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    7fdffa9 View commit details
    Browse the repository at this point in the history

  3. Allow sync call of httpClient.destroy() in a timeout event

    @nherment
    nherment committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    782c9a7 View commit details
    Browse the repository at this point in the history