Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add padding value for mask #189

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

puhoshville
Copy link
Contributor

@puhoshville puhoshville commented Jul 11, 2019

I have noticed that the image and ground truth are processing in the same way, but this entails difficulties when they have different color schemes. So I made a new do_mask function that handles ground_truth images.

Example of usage:

    p.rotate_without_crop(
        probability=0.7,
        max_left_rotation=10,
        max_right_rotation=10,
        fillcolor=(255, 255, 255),  # will apply to image
        mask_fillcolor=127,  # will apply to grayscale ground truth 
    )

Relates to #165


This change is Reviewable

@mdbloice
Copy link
Owner

Hi @puhoshville I will take a look a closer look at this soon, and merge it once I've done so. Thanks for the efforts!
M.

@puhoshville
Copy link
Contributor Author

Did some refactoring.
Also, there is an issue with white lines and I don't know how can I fix it:
original_original_ISIC_0000001 jpg_3d502b08-4955-4195-9404-94a929751b51

@mdbloice
Copy link
Owner

Hi @puhoshville are the white lines something to do with aliasing maybe? And that anti-aliasing needs to be applied which may not be the case by default (I cannot remember off the top of my head).

@puhoshville
Copy link
Contributor Author

@mdbloice sorry I didn't check it before - there is white lines problem on commit e6ef7bc - it's before my contributions, so I created a separate issue to handle it. You can review current PR and merge it if all is ok.

@puhoshville
Copy link
Contributor Author

@mdbloice, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants