Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

suggest: implement caching #28

Closed
mdempsky opened this issue May 2, 2018 · 8 comments
Closed

suggest: implement caching #28

mdempsky opened this issue May 2, 2018 · 8 comments

Comments

@mdempsky
Copy link
Owner

mdempsky commented May 2, 2018

In generating suggestions for cmd/compile/internal/ssa, the two big time overheads are:

  1. Parsing the sibling source files within the package
  2. Loading imports

If we could cache these results, then we'd be on par with nsf/gocode for suggestion performance.

@mdempsky
Copy link
Owner Author

mdempsky commented May 2, 2018

In the cache branch, I've prototyped caching for both of these. Suggestions within cmd/compile/internal/gc now take on the order of 30ms to 40ms with a warm cache.

@OneOfOne
Copy link

I've been using this for a few days now (with both go 1.10 and master), I didn't run into any issues and does seem as fast if not faster than nsf's.

@OneOfOne
Copy link

OneOfOne commented Jul 5, 2018

Any chance this could be merged to make it easier to pull from editors that use this gocode fork?

@OneOfOne
Copy link

OneOfOne commented Jul 5, 2018

Using -source without this branch is pretty much unusable on a big'ish repo.

@abennett
Copy link

Let us know what support we can provide.

@phenixrizen
Copy link

#51 Implements a cache and solves this issue

@charlievieth
Copy link

See: #55 and #54 as well.

@stamblerre
Copy link
Collaborator

Cache branch was merged in #71.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants