Parse files in parallel and only parse buildable files #54
Conversation
This commit introduces two changes. The first is to parse other package files in parallel. The second is to only parse files that would be considered buildable by go/build. Using go/build.Import() is relatively slow and cannot be parallelized (it must run before the parallel parse). To get around using go/build, this commit adds a package 'buildutil', which is a slimmed down version of github.com/charlievieth/buildutil, that can quickly determine if a package should be included. In order for 'buildutil' to respect the PackedContext passed in by the client - it was added as a field to suggest.Config, which is populated by the server.
|
Tests pass on Go versions 1.10.3 and go1.11.0 on Linux and Darwin. Tests also pass on Linux with the latest development version of Go:
|
|
There is a follow on PR to move That will make the separation of concerns a little cleaner under the |
|
bump |
|
@charlievieth I suspect these changes will be superseded by an upcoming change that is currently being tested out in https://github.com/stamblerre/gocode, namely support for #46. That support uses the new cc @stamblerre and @matloob |
|
SGTM. Let me know if you'd like for me to close this PR (#54) and my other one (#55 - parse files in parallel) since go/packages does that already. |
|
Yeah, I'm sorry about this, but I think it may not be worth it to accept these PRs because of our planned migration to go/packages. |
|
np, happy to close. |
This commit introduces two changes. The first is to parse other package files in parallel. The second is to only parse files that would be considered buildable by go/build.
Using go/build.Import() is relatively slow and cannot be parallelized (it must run before the parallel parse). To get around using go/build, this commit adds a package 'buildutil', which is a slimmed down version of github.com/charlievieth/buildutil, that can quickly determine if a package should be included. In order for 'buildutil' to respect the PackedContext passed in by the client - it was added as a field to suggest.Config, which is populated by the server.