Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

cache packages to improve speed #71

Merged
merged 18 commits into from
Oct 16, 2018
Merged

cache packages to improve speed #71

merged 18 commits into from
Oct 16, 2018

Conversation

stamblerre
Copy link
Collaborator

Merge the caching branch into master. The cache branch reads export data files and caches them. If no export data is available, the cache importer falls back to the source importer, and it caches its results for a certain limited amount of time (20 minutes now, can be changed). The cache importer works with packages in a gb layout. If the -source flag is specified, the original gbimporter with the underlying source importer is used. Future work would involve merging these two importers, as there is a bit of duplicated code here.

@stamblerre stamblerre requested a review from ianthehat October 16, 2018 16:44
Copy link
Collaborator

@ianthehat ianthehat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

@stamblerre stamblerre merged commit 22f3bf7 into master Oct 16, 2018
@stamblerre stamblerre deleted the cache branch October 16, 2018 19:02
@ramya-rao-a
Copy link

@stamblerre This is independent of the -source flag correct? Editors need not do any changes other than users updating their gocode, right?

@stamblerre
Copy link
Collaborator Author

@ramya-rao-a, yeah this is just an improvement to gocode. The -source flag should still work as it did previously. Let me know if you encounter any bugs, but it shouldn't change anything (except for hopefully improve speed!).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants