Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guideline for no all-false features #16648

Merged
merged 1 commit into from
Jun 19, 2022
Merged

Add a guideline for no all-false features #16648

merged 1 commit into from
Jun 19, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR fixes #10619 by adding guidelines for preventing all-false features in BCD.

@github-actions github-actions bot added the docs ✍️ Issues or pull requests regarding the documentation of this project. label Jun 13, 2022
@bershanskiy
Copy link
Contributor

Some features may already be added to BCD that do not have any browser support. These features will be removed over time.

We can tweak "obsolete" data tests to also accommodate for this. Should I file a PR for that? Is there a timeline when this guideline will be merged/declined?

@queengooborg
Copy link
Collaborator Author

There's an open PR to add a linter for this, as well as multiple PRs to remove these features -- see #6809, #6854 and #6956. Either way though, I think we're ready to merge this PR!

@queengooborg queengooborg merged commit 66d74a8 into mdn:main Jun 19, 2022
@queengooborg queengooborg deleted the docs/no-all-false branch June 19, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Destop-Trang1801 Destop-Trang1801 Destop-Trang1801 approved these changes

Assignees
No one assigned
Labels
docs ✍️ Issues or pull requests regarding the documentation of this project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data guideline for all false features
3 participants
@queengooborg @bershanskiy @Destop-Trang1801