Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-supported HTTP headers #6956

Closed
wants to merge 10 commits into from
Closed

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Oct 16, 2020
Base automatically changed from master to main March 24, 2021 12:54
@Mouvedia
Copy link

Do not remove set-cookie2 and cookie2; it was supported by Opera.

Disable Cookie2 by default, with an option to enable it again

@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 16, 2021
@Elchi3
Copy link
Member

Elchi3 commented Apr 1, 2022

Do not remove set-cookie2 and cookie2; it was supported by Opera.

#15405 removed them already and I agree to not have them anymore. We have a policy for when we consider features as irrelevant: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features. The headers were last supported in 2011, so data removal is okay.

@Elchi3
Copy link
Member

Elchi3 commented Apr 1, 2022

Seems like some of these features are removed already. I think the feature-policy layout-animations might be one left to remove. A rebase could reveal more.

@Mouvedia
Copy link

Mouvedia commented Apr 1, 2022

We have a policy for when we consider features as irrelevant: https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features.

@Elchi3 you single handedly proposed that guideline the 21/04/2020 and it was merged the next day.
No one had the time to voice their concerns. Only 2 persons were involved in #6018.
This is wrong.

It is obvious that something called browser-compat-data ought to be exhaustive or at least it should be the goal.
A lot of tooling use that data, it should be complete. There are millions of old codebases to maintain.

@queengooborg
Copy link
Collaborator

Hi @Mouvedia, all of our data guidelines reflect project convention and consensus, and the reason the PR adding the guideline was merged so quickly was because it was already settled across various other issues/PRs and offline discussion (that is, meetings/chats through Matrix, Zoom, etc.). We'll take your comments into consideration should we ever revisit the guideline!

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@saschanaz saschanaz closed this Feb 26, 2023
@saschanaz saschanaz deleted the nosupport-http branch February 26, 2023 08:25
@queengooborg queengooborg removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants