Add compat data for input-password #2235

maboa · 2018-06-08T09:58:35Z

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/password

@Elchi3 @wbamberg please let me know if I've dealt with the attributes properly, and further whether we should 'retrofit' to other input types. Thanks!

ddbeck

Looks great, @maboa. I don't have an opinion on the subfeatures, apart from my comments—so you might want to wait for the reviews you actually requested before acting on my comments. Thank you!

ddbeck · 2018-06-22T12:22:29Z

html/elements/input/password.json

+                },
+                "firefox": {
+                  "version_added": "1",
+                  "notes": "Firefox will, unlike other browsers, by default, <a href='http://stackoverflow.com/q/5985839/432681'>persist the dynamic disabled state and (if applicable) dynamic checkedness</a> of an <code><input></code> across page loads. Setting the value of the <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-autocomplete'>autocomplete</a></code> attribute to <code>off</code> disables this feature; this works even when the <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-autocomplete'>autocomplete</a></code> attribute to <code>off</code> attribute would normally not apply to the <code><input></code> by virtue of its <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-type'>type</a></code>. See <a href='https://bugzil.la/654072'>bug 654072</a>."


<input> needs to be escaped here (i.e., <input>)

ddbeck · 2018-06-22T12:25:45Z

html/elements/input/password.json

+              "support": {
+                "chrome": {
+                  "version_added": "5",
+                  "notes": "In 6.0 it only worked with the HTML5 document type, validation support in 7.0 was disabled and re-enabled in 10.0."


It seems to me like this would be easier to understand as an array of entries:

Version added 10

Version added 5, version removed 7, with a note about Chrome 6 HTML5 doctype restriction

ddbeck · 2018-06-22T12:36:21Z

html/elements/input/password.json

+              "support": {
+                "chrome": {
+                  "version_added": "5",
+                  "notes": "Chrome 10 added support for <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/select'><select></a></code> element."


<select> needs to be escaped here (i.e., <select>)

I don't think this is relevant to password inputs, is it?

ddbeck · 2018-06-22T12:46:13Z

html/elements/input/password.json

+              "support": {
+                "chrome": {
+                  "version_added": null,
+                  "notes": "implementing something similar"


I think this note should be dropped, since it's not particularly informative

ddbeck · 2018-06-22T12:46:21Z

html/elements/input/password.json

+                },
+                "chrome_android": {
+                  "version_added": null,
+                  "notes": "implementing something similar"


I think this note should be dropped

ddbeck · 2018-06-22T12:50:39Z

html/elements/input/password.json

+              },
+              "status": {
+                "experimental": false,
+                "standard_track": true,


I couldn't find any standard to back this up, so I think it ought to be false

ddbeck · 2018-06-22T12:50:47Z

html/elements/input/password.json

+              },
+              "status": {
+                "experimental": false,
+                "standard_track": true,


I couldn't find any standard to back this up, so I think it ought to be false

wbamberg · 2018-06-22T20:28:19Z

This is an odd one. The original table has couple of generic problems:

it includes things that aren't relevant to password inputs (e.g. the note Missing for type="checkbox" and type="radio")
it includes things that are relevant, but are global attributes not specific to password (most of the rows in fact)

For (1) we should just omit them. For (2) I think it comes down to policy: should we include global attributes in each input type? For the other types we haven't: we've only included subfeatures where there is something interesting to say.

On the one hand, completeness argues that we should include them: after all it's relevant (and possibly even true!) that, say, Chrome added support for the form attribute for password inputs in version 9.

On the other hand, it's hard to imagine this is useful information to anyone at this point.

I would vote for omitting these, but would welcome other views too :). @Elchi3 ?

wbamberg

A few comments inline. We should remove the stuff that's not relevant to password inputs, and possibly remove the global attribute data.

wbamberg · 2018-06-22T20:31:39Z

html/elements/input/password.json

+                },
+                "firefox": {
+                  "version_added": "1",
+                  "notes": "Firefox will, unlike other browsers, by default, <a href='http://stackoverflow.com/q/5985839/432681'>persist the dynamic disabled state and (if applicable) dynamic checkedness</a> of an <code><input></code> across page loads. Setting the value of the <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-autocomplete'>autocomplete</a></code> attribute to <code>off</code> disables this feature; this works even when the <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-autocomplete'>autocomplete</a></code> attribute to <code>off</code> attribute would normally not apply to the <code><input></code> by virtue of its <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/input#attr-type'>type</a></code>. See <a href='https://bugzil.la/654072'>bug 654072</a>."


This isn't at all specific to password inputs. It should be attached to the data for the generic input element.

wbamberg · 2018-06-22T20:32:19Z

html/elements/input/password.json

+                },
+                "ie": {
+                  "version_added": "6",
+                  "notes": " Missing for <code>type='checkbox'</code> and <code>type='radio'</code>."


This isn't relevant to password inputs.

wbamberg · 2018-06-22T20:32:46Z

html/elements/input/password.json

+              "support": {
+                "chrome": {
+                  "version_added": "5",
+                  "notes": "Chrome 10 added support for <code><a href='https://developer.mozilla.org/docs/Web/HTML/Element/select'><select></a></code> element."


I don't think this is relevant to password inputs, is it?

wbamberg · 2018-06-22T20:34:37Z

html/elements/input/password.json

+              }
+            }
+          },
+          "crossed-lock": {


I'm not sure this is appropriate to include in the data for the password input. It is sort of relevant but only indirectly. It seems more like a generic browser UI decision rather than some aspect of the input itself.

wbamberg · 2018-06-22T20:38:54Z

html/elements/input/password.json

+          },
+          "insecure-login": {
+            "__compat": {
+              "description": "Message displayed next to password field to indicate insecure login page, plus autofill disabled",


This seems like putting documentation in the description field. This does seem more relevant to password than "crossed-lock", but perhaps it would be better for the description to be kept short and there to be text in the main doc fleshing it out? Like "Special handling of password inputs in insecure login pages"?

Not much shorter :) but I think it is better for the MDN page body to include the description of exactly what the browser does in this situation.

Elchi3 · 2018-06-25T10:57:14Z

I agree to omitting global attributes or things not specific to input-password for now.
If these things have specific compat data just in the case of input-password, we can add them later on and see them as "overrides" to the generic input data.

Elchi3 · 2018-06-27T18:12:30Z

@ddbeck can you fix this one up? I'm happy to re-review afterwards.

ddbeck · 2018-06-28T11:33:30Z

@Elchi3 Yes, will do! I'll tag you when it's done

I'm too close to it now

ddbeck · 2018-06-28T14:02:18Z

@Elchi3 OK, I think this is ready for your your review now. Thank you!

Elchi3

Thank you Mark and Daniel! 👍

Review comments addressed. We've removed non-password related things altogether

* master: (175 commits) Add Server-Timing header (mdn#2148) 40th alpha version Add compat data for input-password (mdn#2235) Add addTransceiver() method for RTCPeerConnection. (mdn#2311) Update Payments API for Chrome. (mdn#2378) Add compat data for MutationObserver (mdn#2094) Fix compat data for "let" in Chrome (mdn#1632) Safari has more formdata support now (mdn#2376) Add compat data for Window sub features from A to F (mdn#2109) Add guidelines around worker support and constructors for API subfeatures (mdn#2373) Update place-content.json (mdn#2240) Add compat data for HTMLDetailsElement (mdn#2315) Add compat data for input-month (mdn#2204) Add compat data to input-week (mdn#2230) Add compat data for input-radio (mdn#2208) Add compat data for input-tel (mdn#2226) Add compat data for input-image (mdn#2207) Add compat data for input-number (mdn#2206) Add compat data for input-hidden (mdn#2203) Add compat data for input-file (mdn#2202) ...

maboa added 2 commits June 8, 2018 11:57

Add compat data for input-password

514de06

fixed linting errors

74150e6

Elchi3 added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jun 13, 2018

ddbeck previously requested changes Jun 22, 2018

View reviewed changes

wbamberg previously requested changes Jun 22, 2018

View reviewed changes

ddbeck added 3 commits June 28, 2018 14:54

Remove subfeatures that are not specific to the password input type

5c6d55f

Rename password input type's insecure pages feature

8896db5

Fix insecure login handling feature's spec status

65b8b21

Elchi3 approved these changes Jun 28, 2018

View reviewed changes

Elchi3 merged commit a758091 into mdn:master Jun 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compat data for input-password #2235

Add compat data for input-password #2235

maboa commented Jun 8, 2018

ddbeck left a comment

ddbeck Jun 22, 2018

ddbeck Jun 22, 2018

ddbeck Jun 22, 2018

wbamberg Jun 22, 2018

ddbeck Jun 22, 2018

ddbeck Jun 22, 2018

ddbeck Jun 22, 2018

ddbeck Jun 22, 2018

wbamberg commented Jun 22, 2018

wbamberg left a comment

wbamberg Jun 22, 2018

wbamberg Jun 22, 2018

wbamberg Jun 22, 2018

wbamberg Jun 22, 2018

wbamberg Jun 22, 2018

Elchi3 commented Jun 25, 2018

Elchi3 commented Jun 27, 2018

ddbeck commented Jun 28, 2018

ddbeck commented Jun 28, 2018

Elchi3 left a comment

Add compat data for input-password #2235

Add compat data for input-password #2235

Conversation

maboa commented Jun 8, 2018

ddbeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wbamberg commented Jun 22, 2018

wbamberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Elchi3 commented Jun 25, 2018

Elchi3 commented Jun 27, 2018

ddbeck commented Jun 28, 2018

ddbeck commented Jun 28, 2018

Elchi3 left a comment

Choose a reason for hiding this comment