Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidelines around worker support and constructors for API subfeatures #2373

Merged
merged 2 commits into from
Jun 27, 2018

Conversation

connorshea
Copy link
Contributor

I'm not sure if this is how this should be written out, would appreciate any feedback :)

As requested in #2362.

@Elchi3 Elchi3 added the docs Issues or pull requests regarding the documentation of this project. label Jun 26, 2018
@Elchi3
Copy link
Member

Elchi3 commented Jun 27, 2018

Looks good to me. Maybe the section should start with:
"The following conventions apply to compat data in the api/ folder:"

@connorshea
Copy link
Contributor Author

@Elchi3 updated :)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💯

@Elchi3 Elchi3 merged commit 5aac2a8 into mdn:master Jun 27, 2018
germain-gg pushed a commit to germain-gg/browser-compat-data that referenced this pull request Jun 29, 2018
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
@connorshea connorshea deleted the add-api-subfeature-rules branch July 10, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants