Editorial: Add CustomElementRegistry platform support #623

snuggs · 2017-11-11T17:48:33Z

√ CustomElementRegistry` Basic support
√ CustomElementRegistry.define()` support
√ CustomElementRegistry.get()` get
√ CustomElementRegistry.whenDefined()` whenDefined

Related MDN Documentation:
- CustomElementRegistry.define() - https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/define
- CustomElementRegistry.get() - https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/get
- CustomElementRegistry.whenDefined() - https://developer.mozilla.org/en-US/docs/Web/API/CustomElementRegistry/whenDefined

References:
- Can I Use - https://caniuse.com/#feat=custom-elementsv1
- Chrome Status - http://www.chromestatus.com/feature/4696261944934400
- Firefox Status - https://platform-status.mozilla.org/#custom-elements
- Webkit Status - http://webkit.org/status.html#feature-custom-elements
- Edge Status - http://status.modern.ie/customelements

Notes:
- Firefox flag status - https://bugzilla.mozilla.org/show_bug.cgi?id=889230#c9

snuggs · 2017-11-11T17:50:01Z

If this looks like i'm going in the right direction I can implement the following nested methods:

√ CustomElementRegistry.define()` support
√ CustomElementRegistry.get()` get
√ CustomElementRegistry.whenDefined()` whenDefined

Also noticed broken build.

Please advise

teoli2003

It is overall quite good. Most of the comments are the usual suspects when doing it for the first time.

teoli2003 · 2017-11-12T06:41:44Z

api/CustomElementRegistry.json

+        "support": {
+          "chrome": {
+            "version_added": "33",
+            "notes": "Chrome 36+/Opera 20+ implemented a previous version of Custom Elements (v0) that used `.registerElement()`"


Opera 20+ has nothing to do here, it is an entry about Chrome.
Chrome 36+ is unclear, we write it clear "From Chrome 36, …" (formulation can be done a bit differently).

Also it looks like the note is a restriction/limitation that has been added after the initial release (33). Are you sure of this?

Yes a bit confusing going back and forth between caniuse. I feel there are some misleading statements. Perhaps need to address there. Looks like 54 is v1 true version.

Fixed in 85a11a3

teoli2003 · 2017-11-12T06:42:26Z

api/CustomElementRegistry.json

+            "version_added": "41",
+            "notes": "Supports 'Autonomous custom elements' but not 'Customized built-in elements'"
+          },
+


No empty line please

Fixed in: c9714c4

teoli2003 · 2017-11-12T06:42:38Z

api/CustomElementRegistry.json

+            "notes": "Supports 'Autonomous custom elements' but not 'Customized built-in elements'"
+          },
+
+


No empty line

Fixed in: c9714c4

teoli2003 · 2017-11-12T06:43:42Z

api/CustomElementRegistry.json

+          },
+
+
+          "chrome_android": {


Please put entries in this order:
webview_android, chrome, chrome_android, edge, edge_mobile, firefox, firefox_android, ie, ie_mobile, opera, opera_android, safari, safari_ios.

Thank you.

Hmmm out of curiosity why webview first @teoli2003? Also firefox_android has no specs as far as caniuse goes. For future reference do we totally remove or put null?

Fixed in: f17a21a

Also took the liberty to update documentation #625 as per your recommendation.

teoli2003 · 2017-11-12T06:44:27Z

api/CustomElementRegistry.json

+
+          "chrome_android": {
+            "version_added": "61",
+            "notes": "Supports 'Autonomous custom elements' but not 'Customized built-in elements'"


At first look, I think customized built-in elements should be a subfeature here.

@teoli2003 not sure I follow. I merely used GainNode as a reference point so not sure I know how to do this as this was not in there. Any examples?

teoli2003 · 2017-11-12T06:52:35Z

api/CustomElementRegistry.json

+          },
+          "safari": {
+            "version_added": "10.1",
+            "notes": "Supports 'Autonomous custom elements' but not 'Customized built-in elements'"


At first look, I think customized built-in elements should be a subfeature here.

@teoli2003 are we certain? Because the implementors (vendors) have no immediate plan to support this (with the exception of Chrome).

Please advise and I will update accordingly.

@teoli2003 also would .define(), .get(), & .whenDefined() be considered "Sub-Features"?

teoli2003 · 2017-11-12T06:52:41Z

api/CustomElementRegistry.json

+    "CustomElementRegistry": {
+      "__compat": {
+        "mdn_url": "https://developer.mozilla.org/docs/Web/API/CustomElementRegistry",
+        "description": "The CustomElementRegistry interface provides methods for registering custom elements and querying registered elements.",


We usually don't add a description at the interface level (it is more for subfeature that are neither interfaces, methods nor properties.

Fixed in 5953258

teoli2003 · 2017-11-12T06:53:57Z

api/CustomElementRegistry.json

+        "support": {
+          "chrome": {
+            "version_added": "33",
+            "notes": "Chrome 36+/Opera 20+ implemented a previous version of Custom Elements (v0) that used `.registerElement()`"


"chrome_android" has an additional restriction note, as well as safari. Doesn't it apply to "chrome" too? (And Opera): if so, they have to be added to each fo them.

@teoli2003 how do we do multiple notes...an array? Perhaps i need to RTFM more hehe. ;-)

Fixed in: f8186a5

teoli2003 · 2017-11-12T06:55:00Z

api/CustomElementRegistry.json

+            "version_added": false
+          },
+          "opera_android": {
+            "version_added": false


Are you sure Opera restrict this to the desktop version?

yup @teoli2003

Fixed in: b734b34

Addresses: - #623 (comment)

snuggs · 2017-11-12T12:40:55Z

@teoli2003 addressed all of your concerns. Besides a couple of nits this patch should be more to your liking.

snuggs · 2017-11-12T15:08:27Z

@teoli2003 just came across flags section. Seemed a little vague after reading this. Not certain if this is what you are looking for re: firefox flag. a140245

References: - https://github.com/mdn/browser-compat-data/blob/master/compat-data-schema.md#flags

References: - #623 (comment)

Elchi3

Just one nit and I think this should be good.

Elchi3 · 2017-11-22T20:57:07Z

api/CustomElementRegistry.json

+          },
+          "firefox": {
+            "version_added": true,
+            "notes": "Enabled through the `dom.webcomponents.enabled` preference in `about:config`",


This note is not needed, the MDN compat tables generate a consistent note from the flag object which we can also localize in the future. Please remove.

fyi, the generated note will be:

"This feature is behind the dom.webcomponents.enabled preference (needs to be set to true). To change preferences in Firefox, visit about:config."

@Elchi3 pardon my inexperience this schema is super confusing at least to me. Why would that not be a note of the flags section?

The flag section contains all the information about the pref to enable. There is no need to write the note explicitely. From the flag section information, macros can generate the note synthetically.

Ah I see. Great explanation @teoli2003.

@teoli2003 Fixed in @teoli2003 Fixed in 0b27628

Addresses: - #623 (comment)

Elchi3

Thanks!

snuggs · 2017-11-27T18:00:39Z

@teoli2003 @Elchi3 next steps? Should we merge this or shall I complete .whenDefined .get and .define ? They are rather simple implementations from compat data.

Please advise...

teoli2003 · 2017-11-27T18:31:43Z

@snuggs I propose that you complete the three missing and we do a final review before merging all of them. The next package published will be next Monday, so we don't need to rush here.

snuggs · 2017-11-28T05:35:59Z

Fantastic @teoli2003. Also is there a quick briefing how these get moved over to MDN? I started noticing updates to COMPAT tables recently but can't seem to find a tutorial on the code references when editing MDN docs. Any help would be appreciated.

Elchi3 · 2017-11-28T11:37:42Z

There is an MDN help page available about this: https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/Compatibility_tables

Elchi3 · 2017-12-01T14:49:09Z

I think we should merge this. We're planning to slightly change the schema for the flag property and this PR would be affected / would need a rebase afterwards. To avoid that, this chunk could get merged now, and when you're ready to add more, we might already have the updated schema. What do you think @teoli2003?

teoli2003

lGTM, r+.

Thanks a lot!

teoli2003 · 2017-12-03T08:42:46Z

Yes, yolu are right. Let's merge this.

snuggs · 2017-12-04T01:14:28Z

Awesome! Feels great! Looking forward to more @teoli2003

snuggs · 2018-01-11T06:07:11Z

@teoli2003 @Elchi3 just realized I need to complete the following APIs:

~~CustomElementRegistry Basic support~~
CustomElementRegistry.define()
CustomElementRegistry.get()
CustomElementRegistry.whenDefined()

How are we doing on the new schema update? I figured if given some time over holidays things would be a little more stable. Please advise on how I can wrap this up. 🙏

teoli2003 reviewed Nov 12, 2017

View reviewed changes

snuggs added 6 commits November 12, 2017 13:19

Editorial: Remove description from interface level

5953258

Addresses: - #623 (comment)

Editorial: Fix Chrome versions and notes

85a11a3

Addresses: - #623 (comment)

Editorial: Add additional restriction notes

f8186a5

Addresses: - #623 (comment)

Editorial: Remove empty lines

c9714c4

Addresses: - #623 (comment)

Editorial: Update entry order

f17a21a

Addresses: - #623 (comment)

Editorial: Fix opera_android notes

b734b34

Addresses: - #623 (comment)

snuggs mentioned this pull request Nov 12, 2017

Editorial: Update browser identifier declaration instructions #625

Merged

Editorial: CustomElementRegistry Set flags for firefox

4207782

References: - https://github.com/mdn/browser-compat-data/blob/master/compat-data-schema.md#flags

snuggs mentioned this pull request Nov 12, 2017

Shouldn't compat_block be named support_block within schema? #626

Closed

Convert flags to flag

a140245

snuggs mentioned this pull request Nov 12, 2017

Editorial: Fix schema documentation for flag #627

Merged

2 tasks

teoli2003 pushed a commit that referenced this pull request Nov 13, 2017

Editorial: Update browser identifier declaration instructions (#625)

9a86b4f

References: - #623 (comment)

Elchi3 requested changes Nov 22, 2017

View reviewed changes

Editorial: Remove note from CustomElementRegistry firefox support

0b27628

Addresses: - #623 (comment)

Elchi3 approved these changes Nov 27, 2017

View reviewed changes

Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 28, 2017

teoli2003 approved these changes Dec 3, 2017

View reviewed changes

teoli2003 merged commit a06278e into mdn:master Dec 3, 2017

This was referenced Jan 4, 2018

Notify MDN about changes whatwg/meta#62

Closed

Add caniuse info boxes like the HTML spec whatwg/dom#69

Closed

snuggs deleted the custom-element-registry branch January 11, 2018 06:04

		"notes": "Supports 'Autonomous custom elements' but not 'Customized built-in elements'"
		},

Editorial: Add CustomElementRegistry platform support #623

Editorial: Add CustomElementRegistry platform support #623

Conversation

snuggs commented Nov 11, 2017 • edited Loading

snuggs commented Nov 11, 2017 • edited Loading

teoli2003 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuggs Nov 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

snuggs Nov 12, 2017 • edited Loading

Choose a reason for hiding this comment

snuggs commented Nov 12, 2017

snuggs commented Nov 12, 2017 • edited Loading

Elchi3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Elchi3 left a comment

Choose a reason for hiding this comment

snuggs commented Nov 27, 2017

teoli2003 commented Nov 27, 2017

snuggs commented Nov 28, 2017

Elchi3 commented Nov 28, 2017

Elchi3 commented Dec 1, 2017

teoli2003 left a comment

Choose a reason for hiding this comment

teoli2003 commented Dec 3, 2017

snuggs commented Dec 4, 2017

snuggs commented Jan 11, 2018 • edited Loading

snuggs commented Nov 11, 2017 •

edited

Loading

snuggs commented Nov 11, 2017 •

edited

Loading

snuggs Nov 12, 2017 •

edited

Loading

snuggs Nov 12, 2017 •

edited

Loading

snuggs commented Nov 12, 2017 •

edited

Loading

snuggs commented Jan 11, 2018 •

edited

Loading