Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix schema documentation for flag #627

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Editorial: Fix schema documentation for flag #627

merged 1 commit into from
Nov 21, 2017

Conversation

snuggs
Copy link
Contributor

@snuggs snuggs commented Nov 12, 2017

This was annoying to no end and had to make 2 dozen changes before figured out it was flag not flags.

  • - Change documentation flags -> flag
  • - Provide example for flag

Addresses:
- #626

References:
- #623
- a140245

This was annoying to no end and had to make 2 dozen changes before figured out it was `flag` not `flags`.

  - [x] - Change documentation `flags` -> `flag`
  - [x] - Provide example for `flag`

  Addresses:
    - a140245

  References:
    - #623
@Elchi3
Copy link
Member

Elchi3 commented Nov 21, 2017

I'm very sorry about this nasty typo in our docs!

Note that we now found out that there are multiple flags sometimes, so we're now considering to make this actually flags for real and of type array. See this issue #546

Until that is resolved, this PR looks correct to me, though. So lets merge it.

@Elchi3 Elchi3 added the docs Issues or pull requests regarding the documentation of this project. label Nov 21, 2017
@Elchi3 Elchi3 merged commit f026c86 into mdn:master Nov 21, 2017
@snuggs snuggs deleted the patch-2 branch November 22, 2017 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues or pull requests regarding the documentation of this project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants