-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update when getUserMedia() shipped in Chromium #6658
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navigator.mediaDevices.getUserMedia() and navigator.getUserMedia() were enabled together in M53: https://chromium.googlesource.com/chromium/src/+/d229d009b74255797c16bef6b7e398a165dbeacd The data for navigator.getUserMedia() was already correct, except for Opera where it incorrectly appeared to still be prefixed-only. The change to require a secure context for these APIs was made long before it was shipped: https://chromium.googlesource.com/chromium/src/+/dac67a137b9c8d3be8d51bb9fe8ab761d8b054a7 The versions for api.MediaDevices.getUserMedia.secure_context_required should thus be the same as for the parent feature.
github-actions
bot
added
the
data:api 🐇
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
label
Sep 8, 2020
foolip
commented
Sep 8, 2020
foolip
commented
Sep 8, 2020
Thanks @ddbeck! I'll update the PR to get rid of flags and notes. |
See discussion at https://github.com/mdn/browser-compat-data/pull/6658/files/1c5d3393e722d06fde5527cf7dfc6a477a91a2c8#r485241694 Note that this is *not* supported by the consensus view in mdn#3318
ddbeck
reviewed
Sep 11, 2020
ddbeck
approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent tidying up here, @foolip. Thank you! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.mediaDevices.getUserMedia() and navigator.getUserMedia() were
enabled together in M53:
https://chromium.googlesource.com/chromium/src/+/d229d009b74255797c16bef6b7e398a165dbeacd
The data for navigator.getUserMedia() was already correct, except for
Opera where it incorrectly appeared to still be prefixed-only.
The change to require a secure context for these APIs was made long
before it was shipped:
https://chromium.googlesource.com/chromium/src/+/dac67a137b9c8d3be8d51bb9fe8ab761d8b054a7
The versions for api.MediaDevices.getUserMedia.secure_context_required
should thus be the same as for the parent feature.