Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update when getUserMedia() shipped in Chromium #6658

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Sep 8, 2020

navigator.mediaDevices.getUserMedia() and navigator.getUserMedia() were
enabled together in M53:
https://chromium.googlesource.com/chromium/src/+/d229d009b74255797c16bef6b7e398a165dbeacd

The data for navigator.getUserMedia() was already correct, except for
Opera where it incorrectly appeared to still be prefixed-only.

The change to require a secure context for these APIs was made long
before it was shipped:
https://chromium.googlesource.com/chromium/src/+/dac67a137b9c8d3be8d51bb9fe8ab761d8b054a7

The versions for api.MediaDevices.getUserMedia.secure_context_required
should thus be the same as for the parent feature.

navigator.mediaDevices.getUserMedia() and navigator.getUserMedia() were
enabled together in M53:
https://chromium.googlesource.com/chromium/src/+/d229d009b74255797c16bef6b7e398a165dbeacd

The data for navigator.getUserMedia() was already correct, except for
Opera where it incorrectly appeared to still be prefixed-only.

The change to require a secure context for these APIs was made long
before it was shipped:
https://chromium.googlesource.com/chromium/src/+/dac67a137b9c8d3be8d51bb9fe8ab761d8b054a7

The versions for api.MediaDevices.getUserMedia.secure_context_required
should thus be the same as for the parent feature.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 8, 2020
api/MediaDevices.json Outdated Show resolved Hide resolved
@foolip
Copy link
Collaborator Author

foolip commented Sep 11, 2020

Thanks @ddbeck! I'll update the PR to get rid of flags and notes.

@foolip foolip marked this pull request as ready for review September 11, 2020 11:09
@foolip
Copy link
Collaborator Author

foolip commented Sep 11, 2020

@ddbeck I ended up leaving the notes, but that's not the most important part of this change. This is ready for real review now, and I'll comment on #3318 about why I think it's reasonable to remove flags in a situation like this.

api/MediaDevices.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent tidying up here, @foolip. Thank you! 🎉

@ddbeck ddbeck merged commit d50fead into mdn:master Oct 15, 2020
@foolip foolip deleted the getUserMedia branch October 15, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants