Update Chromium data for api.MediaDevices.getUserMedia #6883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
|
This is a dupe of #6658 which I've unfortunately left sitting for too long. I updated it just today before I got to this PR. |
foolip
reviewed
Oct 13, 2020
| "notes": "Older versions of Chrome implement <code>navigator.webkitGetUserMedia</code>, a prefixed form of the legacy <a href='https://developer.mozilla.org/docs/Web/API/Navigator/getUserMedia'><code>navigator.getUserMedia</code></a> API." | ||
| "version_added": "52", | ||
| "version_removed": "53", | ||
| "prefix": "webkit" |
There was a problem hiding this comment.
Hmm, so you're saying there was navigator.mediaDevices.webkitGetUserMedia for one release? I tested https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=8570 in Chrome 52 and couldn't confirm. The prefixed variant was navigator.webkitGetUserMedia, going back to much further in time.
|
I think this was resolved by #6658. I'm going to close this, but if I've made a mistake please @ me and we'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created based upon the mdn-bcd-collector. It was determined that this function was implemented in Chome 53 rather than 52 -- Chrome 52 implemented it behind a prefix. This also removes the note that talks about the prefixed support (which seems odd that it was added as a note), and removes old flag data.