-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove irrelevant flags in Firefox for AnimationTimeline API #9193
Remove irrelevant flags in Firefox for AnimationTimeline API #9193
Conversation
This PR removes irrelevant flag data for Firefox and Firefox Android for the `AnimationTimeline` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#removal-of-irrelevant-flag-data). This PR was created from results of a [script](https://github.com/vinyldarkscratch/browser-compat-data/blob/scripts/remove-redundant-flags/scripts/remove-redundant-flags.js) designed to remove irrelevant flags.
}, | ||
"firefox_android": { | ||
"version_added": "63", | ||
"flags": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the existing data just wrong here? It seems unlikely this was shipped in desktop but left behind a flag on Android.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could answer my own question and sent #9452.
These changes were made by using mdn-bcd-collector with results from Firefox for Android 86. All changes were originally adding "≤86" and then manually updated to match the Firefox versions. Some things not covered by mdn-bcd-collector might still incorrectly differ between Firefox desktop and Android. This came up in mdn#9193.
…#9452) These changes were made by using mdn-bcd-collector with results from Firefox for Android 86. All changes were originally adding "≤86" and then manually updated to match the Firefox versions. Some things not covered by mdn-bcd-collector might still incorrectly differ between Firefox desktop and Android. This came up in #9193.
I'll go ahead and rebase this on top of #9452 now. |
Oops, now I see this actually can't be removed per https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#removal-of-irrelevant-flag-data, because this stuff was shipped in Firefox 75 and Firefox for Android 79, which was on 2020-04-07 and 2020-07-28, less than two years ago. @vinyldarkscratch I think the script is probably using the date of the entry it's considering removing, rather than the date of the entry/entries that would be left. I'll go ahead and close this, since it could be recreated by the script if tweaked. |
This PR removes irrelevant flag data for Firefox and Firefox Android for the
AnimationTimeline
API as per the corresponding data guidelines.This PR was created from results of a script designed to remove irrelevant flags.