Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant flags in Firefox for AnimationTimeline API #9713

Merged

Conversation

queengooborg
Copy link
Collaborator

This PR removes irrelevant flag data for Firefox and Firefox Android for the AnimationTimeline API as per the corresponding data guidelines.

This PR was created from results of a script designed to remove irrelevant flags.

This PR removes irrelevant flag data for Firefox and Firefox Android for the `AnimationTimeline` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-flag-data).

This PR was created from results of a [script](https://github.com/vinyldarkscratch/browser-compat-data/blob/scripts/remove-redundant-flags/scripts/remove-redundant-flags.js) designed to remove irrelevant flags.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 1, 2021
@foolip
Copy link
Collaborator

foolip commented Apr 2, 2021

@vinyldarkscratch have you fixed the bug in the script that I speculated about in #9193 or do I need to carefully check the dates of the remaining data here?

@queengooborg
Copy link
Collaborator Author

I haven't modified the script per the comments in #9193. For the time being, I'm double-checking the versions and their dates, and discarding changes that don't adhere to the guidelines.

@foolip
Copy link
Collaborator

foolip commented Apr 2, 2021

I see, thanks! In this case since some flags are still left, removing just the oldest statements for a feature doesn't seem very worthwhile. It is allowed per the guideline though.

@ddbeck WDYT?

@ddbeck
Copy link
Collaborator

ddbeck commented Apr 6, 2021

I feel like I'm missing a key thing here: why?

I mean, I can referee the guidelines, but I might be able to do a bit more than that, if I can understand the motivation for this removal. What's the outcome you want from this?

The flag-removal guideline came about in response to a specific goal, to make it easier to reconcile conflicting or messy data and all the earliest removals were in that context. This one's not clearly connected to any context that I know of, so whether or not this is a good idea feels a bit contingent.

@queengooborg
Copy link
Collaborator Author

The reasoning for these PRs is simple: consolidation and simplification. From what I understand, the policy came about as a conflict resolution to aid with contributions. However, from the initial discussion regarding the policy (as well as my own opinion), such flag data isn't really worth maintaining. The increased effort to maintain and verify the flag-based data (especially since it can't really be automated, or if it can, not efficiently), with the lack of maintenance interests from certain browser vendors, and the seemingly low consumer interest, it just seems like a recipe that adds up to scrapping the data. (And I realize the irony of me talking about scrapping old data, considering my reputation of testing in old Internet Explorer 1, 2, 3, etc. 😛)

An added benefit to this flag removal project is catching some data inaccuracies and inconsistencies. For example, if I hadn't gone through with my flag removal script, we wouldn't have found oddities with Firefox for the WebVR APIs, nor would we have found inconsistencies in the (CSS Grid data)[https://github.com//pull/9683] due to modifying Firefox Desktop but not Firefox Android.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, good enough for me. Thank you!

@ddbeck ddbeck merged commit 04fefaf into mdn:main Apr 12, 2021
@queengooborg queengooborg deleted the api/AnimationTimeline/firefox-flagremoval branch April 12, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants