Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant "dom.animations-api.core.enabled" flag #9810

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the now-irrelevant dom.animations-api.core.enabled flag from API data.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 9, 2021
@foolip
Copy link
Collaborator

foolip commented Apr 17, 2021

I don't think that removing parts of the flag data is really improving the data or its maintainability. I'd prefer to leave it in until the entry can be simplified to contain no flag data at all.

@queengooborg
Copy link
Collaborator Author

I was thinking that since this particular flag had been removed from AnimationTimeline already (#9713), we should remove it from the other files containing data for it as well. Happy to wait until we can remove more flags, though.

@foolip
Copy link
Collaborator

foolip commented Apr 19, 2021

OK, I'm a sucker for consistency :)

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to missing "dom.css_pseudo_element.enabled" entried for Firefox for Android, there's also the issue of Firefox for Android dropping support for flags entirely recently.

api/CSSPseudoElement.json Show resolved Hide resolved
api/CSSPseudoElement.json Show resolved Hide resolved
api/Element.json Show resolved Hide resolved
api/Element.json Show resolved Hide resolved
api/Document.json Show resolved Hide resolved
api/DocumentTimeline.json Show resolved Hide resolved
api/DocumentTimeline.json Show resolved Hide resolved
api/Element.json Show resolved Hide resolved
@queengooborg
Copy link
Collaborator Author

queengooborg commented Apr 19, 2021

Added version_removed in all the other locations! I also added a few to Firefox Desktop in the process (since we're here, we might as well tidy up that data a bit, right?).

@foolip foolip merged commit 9fb2c38 into mdn:main Apr 19, 2021
@queengooborg queengooborg deleted the api/animations-api-core-flag branch April 19, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants