-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stop-opacity for Safari iOS and remove duplications (#9402) #9468
Conversation
…stop-opacity from svg.attributes.presentation (#9402)
Oh about this:
Without seeing the diff, I can't be certain, but I suspect you're running a newer version of Node and npm. Since we support the oldest supported LTS, it uses |
I've added the "mdn_url" with the corresponding URL. And |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @Havegum. Thank you! 🎉
* Start release notes for 2021-03-18 release * Add release note for #9438 * Add release note for #9459 * Add release note for #9458 * Add release note for #9382 * Add release note for #9439 * Add release note for #9468 * Add release note for #9472 * Add release note for #9433 * Add release statistics
"safari_ios": [ | ||
{ | ||
"version_added": "3", | ||
"version_removed": "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddbeck did you mean to suggest putting this entry first? Now https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stop-opacity#browser_compatibility makes it look like this isn't supported on iOS at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I did not. I've opened a PR to correct this: #10629
Summary of changes
stop-opacity
to show missing support between versions 11 and 14.stop-opacity
in svg.attributes.presentation following this discussion: svg.attributes.presentation.stop-opacity - missing features in compatibility table #9402Details on testing and verification of support information can also be found in that issue.
Tests and lints passed with no issues.
Although, when running
npm install
the package-lock.json file was modified a bunch, which I since had to unstage before committing. Not sure what the right way to deal with that is, but either way updating dependencies is outside the scope of this PRRelated issue: #9402