Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stop-opacity for Safari iOS and remove duplications (#9402) #9468

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Update stop-opacity for Safari iOS and remove duplications (#9402) #9468

merged 2 commits into from
Mar 16, 2021

Conversation

Havegum
Copy link
Contributor

@Havegum Havegum commented Mar 15, 2021

Summary of changes

Details on testing and verification of support information can also be found in that issue.

Tests and lints passed with no issues.
Although, when running npm install the package-lock.json file was modified a bunch, which I since had to unstage before committing. Not sure what the right way to deal with that is, but either way updating dependencies is outside the scope of this PR

Related issue: #9402

…stop-opacity from svg.attributes.presentation (#9402)
@github-actions github-actions bot added the data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Mar 15, 2021
svg/elements/stop.json Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Mar 16, 2021

Oh about this:

Although, when running npm install the package-lock.json file was modified a bunch, which I since had to unstage before committing. Not sure what the right way to deal with that is, but either way updating dependencies is outside the scope of this PR

Without seeing the diff, I can't be certain, but I suspect you're running a newer version of Node and npm. Since we support the oldest supported LTS, it uses "lockfileVersion": 1, while newer versions try to upgrade to 2. I think the workaround is to use npm ci instead of npm install. Sorry about that!

@Havegum
Copy link
Contributor Author

Havegum commented Mar 16, 2021

I've added the "mdn_url" with the corresponding URL.

And npm ci did the trick! The new commit passed linting and testing – and this time without messing with any package-files! Thanks!

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @Havegum. Thank you! 🎉

@ddbeck ddbeck merged commit 3628ae1 into mdn:master Mar 16, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Mar 16, 2021
ddbeck added a commit that referenced this pull request Mar 18, 2021
* Start release notes for 2021-03-18 release

* Add release note for #9438

* Add release note for #9459

* Add release note for #9458

* Add release note for #9382

* Add release note for #9439

* Add release note for #9468

* Add release note for #9472

* Add release note for #9433

* Add release statistics
"safari_ios": [
{
"version_added": "3",
"version_removed": "11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddbeck did you mean to suggest putting this entry first? Now https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stop-opacity#browser_compatibility makes it look like this isn't supported on iOS at all.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I did not. I've opened a PR to correct this: #10629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants