Merge duplicate SVGGeometryElement+SVGPathElement entries #9479

foolip · 2021-03-16T10:08:35Z

This was tested by checking for the 3 members on all 7 types of elements
which currently inherit from SVGGeometryElement:

http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9076

var tags = ['circle', 'ellipse', 'line', 'path', 'polygon', 'polyline', 'rect'];
var members = ['getPointAtLength', 'getTotalLength', 'pathLength'];
tags.forEach(function(localName) {
  var e = document.createElementNS('http://www.w3.org/2000/svg', localName);
  members.forEach(function(member) {
    w(localName + '.' + member + ': ' + typeof e[member]);
  });
});

In Chromium, getTotalLength and getPointAtLength were moved in M56,
and pathLength was moved in M57:
https://bugs.chromium.org/p/chromium/issues/detail?id=596043
https://storage.googleapis.com/chromium-find-releases-static/887.html#887bbf6c0edcabfa012099379c2d68a3dc4afd3f
https://storage.googleapis.com/chromium-find-releases-static/6fd.html#6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6

In Gecko, the SVGGeometryElement was introduced in 53, but elements
other than were made to inherit in 61:
https://bugzilla.mozilla.org/show_bug.cgi?id=1239100
https://bugzilla.mozilla.org/show_bug.cgi?id=1325320

In WebKit the change was made at trunk version 606.1.14:
https://trac.webkit.org/changeset/230829/webkit
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=230829

In Edge 13 and IE 11, only path.getPointAtLength and path.getTotalLength
were supported, there was no support for pathLength.

In Opera 12.16, all 3 members were supported on path and nowhere else.

Fixes #9183.

This was tested by checking for the 3 members on all 7 types of elements which currently inherit from SVGGeometryElement: http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9076 ```js var tags = ['circle', 'ellipse', 'line', 'path', 'polygon', 'polyline', 'rect']; var members = ['getPointAtLength', 'getTotalLength', 'pathLength']; tags.forEach(function(localName) { var e = document.createElementNS('http://www.w3.org/2000/svg', localName); members.forEach(function(member) { w(localName + '.' + member + ': ' + typeof e[member]); }); }); ``` In Chromium, getTotalLength and getPointAtLength were moved in M56, and pathLength was moved in M57: https://bugs.chromium.org/p/chromium/issues/detail?id=596043 https://storage.googleapis.com/chromium-find-releases-static/887.html#887bbf6c0edcabfa012099379c2d68a3dc4afd3f https://storage.googleapis.com/chromium-find-releases-static/6fd.html#6fd1cbb3c5a636ee3830729e4b26ca1d5d78c8d6 In Gecko, the SVGGeometryElement was introduced in 53, but elements other than <path> were made to inherit in 61: https://bugzilla.mozilla.org/show_bug.cgi?id=1239100 https://bugzilla.mozilla.org/show_bug.cgi?id=1325320 In WebKit the change was made at trunk version 606.1.14: https://trac.webkit.org/changeset/230829/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=230829 In Edge 13 and IE 11, only path.getPointAtLength and path.getTotalLength were supported, there was no support for pathLength. In Opera 12.16, all 3 members were supported on path and nowhere else. Fixes mdn#9183.

foolip · 2021-03-16T10:41:23Z

api/SVGGeometryElement.json

@@ -11,13 +11,13 @@
            "version_added": "18"
          },
          "edge": {
-            "version_added": "≤79"
+            "version_added": "12"


In order to satisfy the lint it's necessary to say that SVGGeometryElement was introduced when some of its members were first introduced on SVGPathElement. I think this is the right thing to do and support for the interface itself isn't very interesting, but should I use partial_implementation for the range where the interface actually didn't exist?

Yes, I think this is the right thing to do. I think it's nice to have the symmetry between the partial_implementation for the subfeatures and the parent. It's a little messy, but the reality is messy too.

OK, I'm going to split and use notes like the one on BaseAudioContext.

Gah, I shouldn't have look at that! It took #9513 + #9514 + #9515 + #9516 to arrive at something to copy.

foolip · 2021-03-16T10:42:12Z

api/SVGGeometryElement.json

-          }
-        }
-      },
-      "supportOtherThanPath": {


This "supportOtherThanPath" entry is removed because it's all represented on the individual entries now.

api/SVGGeometryElement.json

foolip · 2021-03-16T10:49:52Z

api/SVGGeometryElement.json

-            "firefox_android": {
-              "version_added": "61"
-            },
+              "version_added": "79"


This is not a mistake. pathLength wasn't supported in IE or EdgeHTML, confirmed by testing.

foolip · 2021-03-16T10:52:59Z

api/SVGGeometryElement.json

+            ],
+            "opera_android": [
+              {
+                "version_added": "43"


This is not a mistake. The off-by-13 rule held up to Opera 42 on both desktop and mobile, then things got out of sync. Opera desktop 43 was Blink 56, but Android 43 skipped to 59.

These were moved from SVGPathElement to SVGGeometryElement in all implementations, and continuing to document them in two places is not necessary. A similar merge is being done in BCD: mdn/browser-compat-data#9479

ddbeck

This looks good, @foolip. I think the only change needed here is to extend the partial implementation detail to the parent feature. Thank you!

ddbeck · 2021-03-18T11:26:56Z

api/SVGGeometryElement.json

@@ -11,13 +11,13 @@
            "version_added": "18"
          },
          "edge": {
-            "version_added": "≤79"
+            "version_added": "12"


Yes, I think this is the right thing to do. I think it's nice to have the symmetry between the partial_implementation for the subfeatures and the parent. It's a little messy, but the reality is messy too.

foolip · 2021-03-19T13:37:09Z

api/SVGGeometryElement.json

+          ],
+          "firefox": [
+            {
+              "version_added": "53"


This is when SVGGeometryElement itself was introduced in Firefox. It was only later that all interfaces were made to inherit from it. But doing that as 3 entries here does not seem like it would make the situation more clear to anyone. The subfeatures are what matter more here.

Great. I like this pragmatic approach. 👍

ddbeck

Thank you, @foolip! 🎉

foolip added the needs-release-note 📰 label Mar 16, 2021

github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 16, 2021

foolip force-pushed the SVGPathElement-to-SVGGeometryElement branch from 0247888 to 4897a05 Compare March 16, 2021 10:09

foolip marked this pull request as ready for review March 16, 2021 10:40

foolip commented Mar 16, 2021

View reviewed changes

api/SVGGeometryElement.json Outdated Show resolved Hide resolved

Update api/SVGGeometryElement.json

6966f34

foolip commented Mar 16, 2021

View reviewed changes

foolip mentioned this pull request Mar 16, 2021

Redirect SVGPathElement duplicate members to SVGGeometryElement mdn/content#3191

Merged

ddbeck requested changes Mar 18, 2021

View reviewed changes

split entries for api.SVGGeometryElement itself

270700f

foolip commented Mar 19, 2021

View reviewed changes

foolip requested a review from ddbeck March 19, 2021 13:37

foolip mentioned this pull request Mar 22, 2021

How to represent changes/moves on the prototype chain #3463

Closed

ddbeck approved these changes Mar 22, 2021

View reviewed changes

ddbeck merged commit c1ac95b into mdn:master Mar 22, 2021

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Mar 22, 2021

Add release notes for mdn#9479

139394a

foolip deleted the SVGPathElement-to-SVGGeometryElement branch March 22, 2021 18:09

saschanaz mentioned this pull request Oct 4, 2021

Remove invalid deprecation flags #7709

Closed

queengooborg removed the needs-release-note 📰 label Apr 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge duplicate SVGGeometryElement+SVGPathElement entries #9479

Merge duplicate SVGGeometryElement+SVGPathElement entries #9479

foolip commented Mar 16, 2021 •

edited

Loading

foolip Mar 16, 2021

ddbeck Mar 18, 2021

foolip Mar 19, 2021

foolip Mar 19, 2021

foolip Mar 16, 2021

foolip Mar 16, 2021

foolip Mar 16, 2021

ddbeck left a comment

ddbeck Mar 18, 2021

foolip Mar 19, 2021

ddbeck Mar 22, 2021

ddbeck left a comment

Merge duplicate SVGGeometryElement+SVGPathElement entries #9479

Merge duplicate SVGGeometryElement+SVGPathElement entries #9479

Conversation

foolip commented Mar 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ddbeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ddbeck left a comment

Choose a reason for hiding this comment

foolip commented Mar 16, 2021 •

edited

Loading