Add separate entries from BaseAudioContext before it existed #9516
Conversation
github-actions
bot
added
the
data:api
|
Dependencies merged |
Chrome 56 came from mdn-bcd-collector: https://mdn-bcd-collector.appspot.com/tests/api/BaseAudioContext A lot of the Firefox subfeatures needed updating, and almost all of it was confirmed by mdn-bcd-collector results. The "promise_syntax" is the notable exception, where the version in the notes was trusted.
foolip
force-pushed
the
split-BaseAudioContext
branch
from
5ee5522 to
c0c3771
Compare
| @@ -417,10 +473,10 @@ | |||
| "version_added": "79" | |||
| }, | |||
| "firefox": { | |||
| "version_added": "53" | |||
| "version_added": "52" | |||
There was a problem hiding this comment.
This change is not accidental, it's from mdn-bcd-collector results. It matches https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode#browser_compatibility.
| @@ -665,12 +713,10 @@ | |||
| "version_added": "14" | |||
| }, | |||
| "firefox": { | |||
| "version_added": "53", | |||
| "notes": "Originally implemented on <a href='https://developer.mozilla.org/docs/Web/API/AudioContext'><code>AudioContext</code></a> in Firefox 50." | |||
| "version_added": "50" | |||
There was a problem hiding this comment.
| @@ -987,12 +1025,10 @@ | |||
| "version_added": "12" | |||
| }, | |||
| "firefox": { | |||
| "version_added": "53", | |||
| "notes": "Originally implemented on <a href='https://developer.mozilla.org/docs/Web/API/AudioContext'><code>AudioContext</code></a> in Firefox 37." | |||
| "version_added": "37" | |||
There was a problem hiding this comment.
|
@Elchi3 rebased and lightly self-reviewed. |
There was a problem hiding this comment.
I like it. I think notes on the top-level feature regarding prototype moves is a lot better than having notes on all sub features. (and the earlier version number for all these sub features is definitely a better reflection of availability reality!)
Can this is be a model for more cases when prototype moves happened? 👀
|
@Elchi3 Yeah, I think this is an approach that could be use elsewhere too, I've commented in #3463 (comment) |
Chrome 56 came from mdn-bcd-collector:
https://mdn-bcd-collector.appspot.com/tests/api/BaseAudioContext
A lot of the Firefox subfeatures needed updating, and almost all of it
was confirmed by mdn-bcd-collector results. The "promise_syntax" is the
notable exception, where the version in the notes was trusted.