Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add JSON linting scripts #19935

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Conversation

nschonni
Copy link
Contributor

This pins the dependienes and adds the scripts to align with the Markdownlint CI.
This could alternately be swapped with prettier like the open YML lint PR instead of ESLint

@nschonni nschonni requested review from schalkneethling and a team as code owners August 24, 2022 18:44
@nschonni nschonni force-pushed the json-lint-scripts branch 2 times, most recently from fa003aa to 5480db3 Compare August 24, 2022 22:26
@schalkneethling
Copy link
Contributor

This could alternately be swapped with prettier like the open YML lint PR instead of ESLint

Thank you for getting this in place, @nschonni. As it is a standard across our repositories to use Prettier for this kinda work, I would say we should do the same here. Thanks

@nschonni nschonni requested a review from a team as a code owner August 25, 2022 13:56
@nschonni nschonni requested review from bsmth and removed request for a team August 25, 2022 13:56
@nschonni
Copy link
Contributor Author

@schalkneethling I've swapped to the default Prettier formatter. I could use the JSON.stringify one to reduce the folding of arrays to the same line if that would be better

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍🏻

@schalkneethling
Copy link
Contributor

@schalkneethling I've swapped to the default Prettier formatter. I could use the JSON.stringify one to reduce the folding of arrays to the same line if that would be better

I reckon this look and works well, thanks @nschonni

Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@schalkneethling schalkneethling merged commit 8bd4e34 into mdn:main Aug 25, 2022
@nschonni nschonni deleted the json-lint-scripts branch August 25, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants