Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pages for AddressErrors #20167

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Remove pages for AddressErrors #20167

merged 3 commits into from
Aug 31, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Aug 31, 2022

Removed from the spec in w3c/payment-request#955

There are no compat tables on these pages. Probably it wasn't supported anywhere.

@Elchi3 Elchi3 requested review from a team as code owners August 31, 2022 11:59
@Elchi3 Elchi3 requested review from jpmedley and bsmth and removed request for a team August 31, 2022 11:59
@github-actions github-actions bot added the Content:WebAPI Web API docs label Aug 31, 2022
@bsmth
Copy link
Member

bsmth commented Aug 31, 2022

Taking a look 👀

@Elchi3 Elchi3 marked this pull request as draft August 31, 2022 12:00
@Elchi3
Copy link
Member Author

Elchi3 commented Aug 31, 2022

Okay the large change to wiki history was automatic. Not sure why it did that.

@Elchi3
Copy link
Member Author

Elchi3 commented Aug 31, 2022

Okay the large change to wiki history was automatic. Not sure why it did that.

#19935 apparently introduced linting to the file. How do I lint and why does it clash with the CLI command yarn content delete <file>?

@bsmth
Copy link
Member

bsmth commented Aug 31, 2022

Okay the large change to wiki history was automatic. Not sure why it did that.

#19935 apparently introduced linting to the file. How do I lint and why does it clash with the CLI command yarn content delete <file>?

Also relates to #20139

@Elchi3
Copy link
Member Author

Elchi3 commented Aug 31, 2022

ah thanks, waiting for mdn/yari#7032 then. Marked as draft.

@bsmth
Copy link
Member

bsmth commented Aug 31, 2022

ah thanks, waiting for mdn/yari#7032 then. Marked as draft.

Very good, thanks

@Elchi3 Elchi3 marked this pull request as ready for review August 31, 2022 13:52
@Elchi3
Copy link
Member Author

Elchi3 commented Aug 31, 2022

Alright, JSON reformatting solved. Ready to review.

bsmth
bsmth approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍🏻

@bsmth bsmth merged commit 2a6013d into mdn:main Aug 31, 2022
@Elchi3 Elchi3 deleted the rm-addresserrors branch September 1, 2022 07:58
goshdarnheck pushed a commit to goshdarnheck/content that referenced this pull request Sep 7, 2022
@Elchi3 @bsmth @goshdarnheck
Remove pages for AddressErrors (mdn#20167)
40c585f 
* Remove pages for AddressErrors

* Run "fix:json"

Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bsmth bsmth bsmth approved these changes

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @bsmth