-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex reference #22210
Regex reference #22210
Conversation
I for one really like the way this is going @Josh-Cena, folks seem quite positive about this content :) I'll await a little more feedback from others, but I might open a tracking bug for the work moving forward (the roadmap is still a few weeks away which is a shame because this is the perfect thing for it) |
876f1af
to
8a8692e
Compare
Update: I have completed the scaffolds for all pages, but I'm missing a lot of examples, and I also plan to rearrange documentation about regexes in other places. Now is a good time to comment on the description sections, because I feel like I've stuffed in a lot of obscure details. |
08e860d
to
c94bfa9
Compare
47dda5a
to
220e2e7
Compare
220e2e7
to
62d31f3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
BCD for the patterns has been merged in mdn/browser-compat-data#18966 |
This pull request has merge conflicts that must be resolved before it can be merged. |
0b1e8a9
to
4668a77
Compare
4668a77
to
7a368d1
Compare
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @Josh-Cena - thanks for the wonderful improvements here, I'm happy to merge when you are!
One last check about flaws, but I think we're good 👍🏻
title: "Named capturing group: (?<name>...)" | ||
slug: Web/JavaScript/Reference/Regular_expressions/Named_capturing_group | ||
page-type: javascript-language-feature | ||
browser-compat: javascript.regular_expressions.named_capturing_group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shows a flaw which I presume is the "no spec found" warning:
Are we waiting on a BCD release with the latest data from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the flaw is not about the spec data, as spec data is missing on every page, while the flaw is only raised for certain pages. The flaw may be because Yari does not have the latest BCD? As for the missing spec link, I honestly don't know—I'm as puzzled as you are. https://pr22210.content.dev.mdn.mozit.cloud/en-US/docs/Web/JavaScript/Reference/Regular_expressions/Literal_character does have BCD table, which means mdn/browser-compat-data#19050 is already live, and the APIs ought to have spec links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the flaw is only raised for certain pages
That's the strange part - let's merge and keep an eye on this if it's resolved on nightly build, this might be only affecting the PR companion.
Description
See mdn/mdn-community#196
Draft as a demo
Related issues and pull requests