Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CSS shape-rendering property #35228

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

meyerweb
Copy link
Contributor

Description

Adds documentation of the CSS property shape-rendering, which replicates an SVG attribute.

Motivation

The page currently doesn’t exist, and needs to be created (see #34763).

@meyerweb meyerweb requested review from a team as code owners July 29, 2024 20:58
@meyerweb meyerweb requested review from chrisdavidmills and removed request for a team July 29, 2024 20:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed labels Jul 29, 2024
Copy link
Contributor

@bsmth
Copy link
Member

bsmth commented Aug 1, 2024

Thanks, Eric. Taking a look now 👀


## Formal definition

{{CSSInfo}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about missing CSSInfo data. Otherwise looking great

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Josh-Cena’s comment in 35107, the macro should stay even if currently broken. (This is the case on several other CSS pages, in fact.) I can look into adding the information to mdn/data when I return from holiday, but in the meantime I believe this can be merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK got it. I've opened a tracker in mdn/data so we don't forget

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

@bsmth bsmth merged commit 10c7190 into mdn:main Aug 2, 2024
7 checks passed
@meyerweb meyerweb deleted the css/shape-rendering branch August 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants