Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter syntax for Navigation.updateCurrentEntry() #36852

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix parameter syntax for Navigation.updateCurrentEntry() #36852

merged 2 commits into from
Nov 19, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

the Navigation.updateCurrentEntry() must take a options parameter

Motivation

Additional details

see spec idl at https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigation

also test mantually by navigation.updateCurrentEntry() in chrome

Related issues and pull requests

@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Nov 18, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 18, 2024 21:22
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 18, 2024 21:22
@skyclouds2001 skyclouds2001 requested review from wbamberg and removed request for a team November 18, 2024 21:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-11-18 21:31:43)

@github-actions github-actions bot added size/xs [PR only] 0-5 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Nov 18, 2024
wbamberg
wbamberg approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @skyclouds2001 !

@wbamberg wbamberg merged commit b55f5ca into mdn:main Nov 19, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the Navigation.updateCurrentEntry branch November 19, 2024 06:38
wbamberg added a commit to wbamberg/content that referenced this pull request Nov 27, 2024
@wbamberg
Merge remote-tracking branch 'origin/xss-guide' into xss-guide
bc9d568 
* origin/xss-guide: (284 commits)
  Add information on default entryPoint property values (mdn#36633)
  Bump husky from 9.1.6 to 9.1.7 (mdn#36863)
  fix(performance): Typo '50ms seconds' (mdn#36861)
  Add spec_url & add note for bcd for `<frequency>` and `<frequency-percentage>` (mdn#36848)
  addresses 36583: summary icon styles (mdn#36691)
  Remove "simple" part 3: change to "basic"  (mdn#36762)
  the default option of a select (mdn#36658)
  docs(css): Add support for `<string>` in `syntax` descriptor of @Property at-rule (mdn#36655)
  Fix parameter syntax for `Navigation.updateCurrentEntry()` (mdn#36852)
  Update CSP source expression reference (mdn#36792)
  chore(http): Refresh headers docs (d-k) (mdn#36075)
  chore(http): Refresh headers r-s (mdn#36590)
  Updated index.md (mdn#36845)
  fix : wrong method name (mdn#36843)
  Remove all redirects to other locales (mdn#36811)
  fix typos (mdn#36837)
  docs: update Accept-Charset status (mdn#36822)
  updateSelection: make more intuitive (mdn#36834)
  updateText: Remove false information (mdn#36832)
  DOMRect instance properties (mdn#36704)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbamberg wbamberg wbamberg approved these changes

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @wbamberg