Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(http): Refresh headers r-s #36590

Merged
merged 7 commits into from
Nov 18, 2024
Merged

chore(http): Refresh headers r-s #36590

merged 7 commits into from
Nov 18, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Oct 31, 2024

Description

This PR refreshes a few HTTP headers pages.

common changes:

  • Improve See also
  • Capitalize Yes/No in properties table
  • Normalize The HTTP **`Header-Name`** (request|response) header in first sentence
  • Add status text to HTTPStatus macros, e.g. {{HTTPStatus("406", "406 Not Acceptable")}}
  • Remove improper use of quotes in and around code
  • Avoid escaping angle brackets in directive names in favor of backticks:
- \<directive>
+ `<directive>`

Motivation

Keeping content up-to-date, fixing formatting, unifying writing conventions

TODO:

  • Bad BCD queries

@bsmth bsmth requested a review from a team as a code owner October 31, 2024 09:38
@bsmth bsmth requested review from hamishwillee and removed request for a team October 31, 2024 09:38
@github-actions github-actions bot added Content:HTTP HTTP docs size/l [PR only] 501-1000 LoC changed labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

Preview URLs (28 pages)
Flaws (5)

Note! 23 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Key
Title: Sec-WebSocket-Key
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Key

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Accept
Title: Sec-WebSocket-Accept
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Accept

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Version
Title: Sec-WebSocket-Version
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Version

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Protocol
Title: Sec-WebSocket-Protocol
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Protocol

URL: /en-US/docs/Web/HTTP/Headers/Sec-WebSocket-Extensions
Title: Sec-WebSocket-Extensions
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Sec-WebSocket-Extensions
External URLs (19)

URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-Prefers-Reduced-Motion
Title: Sec-CH-Prefers-Reduced-Motion


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-Prefers-Color-Scheme
Title: Sec-CH-Prefers-Color-Scheme


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform
Title: Sec-CH-UA-Platform


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-Prefers-Reduced-Transparency
Title: Sec-CH-Prefers-Reduced-Transparency


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Bitness
Title: Sec-CH-UA-Bitness


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Arch
Title: Sec-CH-UA-Arch


URL: /en-US/docs/Web/HTTP/Headers/RTT
Title: RTT


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA
Title: Sec-CH-UA


URL: /en-US/docs/Web/HTTP/Headers/Retry-After
Title: Retry-After


URL: /en-US/docs/Web/HTTP/Headers/Repr-Digest
Title: Repr-Digest


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Full-Version-List
Title: Sec-CH-UA-Full-Version-List


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Model
Title: Sec-CH-UA-Model


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Mobile
Title: Sec-CH-UA-Mobile


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform-Version
Title: Sec-CH-UA-Platform-Version


URL: /en-US/docs/Web/HTTP/Headers/Sec-GPC
Title: Sec-GPC


URL: /en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Full-Version
Title: Sec-CH-UA-Full-Version


URL: /en-US/docs/Web/HTTP/Headers/Save-Data
Title: Save-Data

(comment last updated: 2024-11-18 17:04:54)

@hamishwillee
Copy link
Collaborator

Aware of this. Hope to get to it next week.

@bsmth
Copy link
Member Author

bsmth commented Nov 1, 2024

Aware of this. Hope to get to it next week.

Thanks, Hamish. There's no rush on the HTTP PRs at the moment.


The registered insecure digest algorithms are: `md5`, `sha` (SHA-1), `unixsum`, `unixcksum`, `adler` (ADLER32) and `crc32c`.
### Usage notes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a mix of "Usage notes" and "Description" sections, related to the previous PR. It would be good to choose a convention for that.

Copy link
Collaborator

@hamishwillee hamishwillee Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I vote description for broader consistency across reference docs of other types.

Not necessarily and easy change though - these usage notes are in some cases just notes. For example here you couldn't just change the heading and expect it to "work" as a fix.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in e996e9a

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I removed the section title in this case)

@@ -7,7 +7,9 @@ spec-urls: https://datatracker.ietf.org/doc/html/rfc9530

{{HTTPSidebar}}

The **`Repr-Digest`** response or request header provides a {{Glossary("digest")}} of the [selected representation](https://www.rfc-editor.org/rfc/rfc9110#section-6.4) of the target resource. It is invariant under e.g., {{HTTPHeader("Content-Encoding")}} or {{HTTPHeader("Content-Range")}}, which do affect the {{HTTPHeader("Content-Digest")}}. Furthermore, [Content Negotiation](/en-US/docs/Web/HTTP/Content_negotiation) can result in different selected representations with different representation digests.
The HTTP **`Repr-Digest`** {{Glossary("Request header", "request")}} and {{Glossary("Response header", "response header")}} provides a {{Glossary("digest")}} of the [selected representation](https://www.rfc-editor.org/rfc/rfc9110#section-6.4) of the target resource.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a glossary entry instead of RFC link for selected representation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed in e996e9a, what do you think?

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth Look great. Just a few suggestions on the early ones.

@bsmth
Copy link
Member Author

bsmth commented Nov 13, 2024

@bsmth Look great. Just a few suggestions on the early ones.

Thanks a lot, I'll take a look shortly 🙏🏻

@bsmth
Copy link
Member Author

bsmth commented Nov 18, 2024

Thanks, Hamish. I think this is mostly done, ready for another look when you have time. I'm going to have a look at BCD for the WebSocket pages 👀

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth The changes you made all look good, so I am going to merge. Note that I only looked at those changes, but I was happy with the rest last time round.

Thanks very much. Nearly there!

@hamishwillee hamishwillee merged commit 6c32e8b into mdn:main Nov 18, 2024
8 checks passed
@bsmth bsmth deleted the http-headers-r branch November 20, 2024 10:00
@bsmth
Copy link
Member Author

bsmth commented Nov 20, 2024

Thanks a lot!

wbamberg added a commit to wbamberg/content that referenced this pull request Nov 27, 2024
* origin/xss-guide: (284 commits)
  Add information on default entryPoint property values (mdn#36633)
  Bump husky from 9.1.6 to 9.1.7 (mdn#36863)
  fix(performance): Typo '50ms seconds' (mdn#36861)
  Add spec_url & add note for bcd for `<frequency>` and `<frequency-percentage>` (mdn#36848)
  addresses 36583: summary icon styles (mdn#36691)
  Remove "simple" part 3: change to "basic"  (mdn#36762)
  the default option of a select (mdn#36658)
  docs(css): Add support for `<string>` in `syntax` descriptor of @Property at-rule (mdn#36655)
  Fix parameter syntax for `Navigation.updateCurrentEntry()` (mdn#36852)
  Update CSP source expression reference (mdn#36792)
  chore(http): Refresh headers docs (d-k) (mdn#36075)
  chore(http): Refresh headers r-s (mdn#36590)
  Updated index.md (mdn#36845)
  fix : wrong method name (mdn#36843)
  Remove all redirects to other locales (mdn#36811)
  fix typos (mdn#36837)
  docs: update Accept-Charset status (mdn#36822)
  updateSelection: make more intuitive (mdn#36834)
  updateText: Remove false information (mdn#36832)
  DOMRect instance properties (mdn#36704)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants