-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): Delete "Digest" and "Want-Digest", improve digest pages #36879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Was tempted to merge, but perhaps worth leaving open for you to see if you want to address any of the comments.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsmth Looks great, except perhaps for suggestion in #36879 (comment)
Approving so you can merge once that's had a look
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Description
This PR removes the Digest and Want-Digest pages which are deprecated. They are also confusing, given the pages are mixed in with newer alternatives. I'm proposing we redirect to content-related digest headers.
Deletions:
Digest
header, redirected toContent-Digest
Want-Digest
header, redirected toWant-Content-Digest
Changes:
Repr-Digest
andContent-Digest
pages for clarityspec_urls
front matter should bespec-urls
Additions:
Content-Digest
based on specsMotivation
The remaining pages were touched recently, but I think there's room for improvement in the language used so that it's easier to understand when/why to use
Repr-Digest
instead ofContent-Digest
.Related issues and pull requests