-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOM Reference] Update CustomEvent interface reference #9920
Conversation
Preview URLs
FlawsNone! 🎉 External URLsURL: No new external URLs URL: No new external URLs URL: No new external URLs URL: No new external URLs (this comment was updated 2021-11-22 10:05:08.024309) |
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Thanks a lot, @jpmedley! This is very helpful. |
@@ -55,5 +50,4 @@ event.initCustomEvent(type, canBubble, cancelable, detail); | |||
## See also | |||
|
|||
- {{domxref("CustomEvent")}} | |||
- The constructor to use instead of this deprecated method: | |||
{{domxref("CustomEvent.CustomEvent", "CustomEvent()")}}. | |||
- The constructor to use instead of this deprecated method: {{domxref("CustomEvent.CustomEvent", "CustomEvent()")}}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important enough that it should be at the top, not in what many may view as extra information.
(Has anyone discussed whether deprecated features should have a heading titled "Alternatives"?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already mentioned in the first section, at the top of the article, in the note:
I think it does no harm to have it at both places, and I 100% agree it has to be mentioned at the top.
For an Alternatives, it is worth discussing. I don't know if we want a heading or a note, but we definitively need the information about the alternative (and near the top of the article) each time something is deprecated or non-standard, or people will continue to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it does no harm to have it at both places
One such item does no harm. I do my best to minimize such repetitions. They are too easily missed during update passes.
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Joe Medley <jmedley@google.com>
Hello, |
It was removed because the section talked about Firefox XUL/XPCOM extension code. We are trying to make MDN Web Docs only about Web technologies. XUL/XPCOM Firefox extensions don't exist anymore so it was removed for that reason. "privileged" referred to privileged code in an extension context. |
Yes, thank you very much! |
This is part of #9740.
CustomEvent
are documented in the modern format.