Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOM Reference] Update CustomEvent interface reference #9920
[DOM Reference] Update CustomEvent interface reference #9920
Changes from 1 commit
90eccd0
c37760e
ab6d719
ab601b9
495d893
9025262
588417d
b4b343f
bbe40fd
2d98cdd
d0239dc
66207c4
af6bf9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is important enough that it should be at the top, not in what many may view as extra information.
(Has anyone discussed whether deprecated features should have a heading titled "Alternatives"?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already mentioned in the first section, at the top of the article, in the note:
I think it does no harm to have it at both places, and I 100% agree it has to be mentioned at the top.
For an Alternatives, it is worth discussing. I don't know if we want a heading or a note, but we definitively need the information about the alternative (and near the top of the article) each time something is deprecated or non-standard, or people will continue to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One such item does no harm. I do my best to minimize such repetitions. They are too easily missed during update passes.