Add color-adjust property example #1008
Conversation
There was a problem hiding this comment.
Thanks for the example @a2sheppy, took a little reading up to realise how this works ;) Two nits, other than that r+w/c
| @@ -0,0 +1,11 @@ | |||
| #example-element { | |||
| padding: 1em; | |||
| font-size: 1.5em; | |||
There was a problem hiding this comment.
Super Nit: Code style: Prefer rem over em for font sizes.
| padding: 1em; | ||
| font-size: 1.5em; | ||
| background-color: black; | ||
| background-image: linear-gradient(rgba(0, 0, 180, 0.5), rgba(70, 140, 220, 0.5)); |
There was a problem hiding this comment.
Nit: Code style: Omit 0 from fractional values
|
Remove the leading "0" from fractional numbers? That's... strange. Leaving out the leading 0 makes the number harder and violates every style guide I've ever seen. |
|
@a2sheppy This has been part of the Kuma stylelint rules for a long time: Here is the documentation from stylelint: It is also part of sass-lint: And also mentioned in Codestyle.io's documentation: I also generally find it to be the format I most encounter. |
|
It's still weird; I've honestly never seen such a thing. I'll make the change, but I think it badly damages legibility of the code. |
|
I've seen both in fairly equal measure, FWIW. I think I prefer "with leading 0s", for similar reasons to those sheppy brings up, but I can live with it. |
|
@a2sheppy @chrisdavidmills Yeah, this is one of those points where there is often contention ;) As we have followed this guideline for the rest of this codebase, and have also been following it on Kuma since before my time, I felt that we should stick with it. |
* upstream/master: (33 commits) Add HTML example for <a> (issue mdn#1014) (mdn#1022) fix(tabbed): load fonts as part of the editor css as @font-face does not work inside shadow dom (mdn#1015) html/input: Lowercase attributes (mdn#1024) Add color-adjust property example (mdn#1008) chore(deps): update dependency eslint to v5.1.0 (mdn#1023) chore(community): add @goodwin64 as contributor (mdn#1021) chore(community): add @dagolinuxoid as contributor (mdn#1020) chore(community): add @arai-a as contributor (mdn#1019) chore(community): add @ro-ka as contributor (mdn#1018) Issue mdn#1013 <style> elements in HTML editor break editor's render method (mdn#1017) chore(deps): update jest monorepo to v23.3.0 (mdn#1012) Issue#946 open links in new tab (mdn#1009) Send metric only during loading event (mdn#1011) fix(performance): only send loading mark inside loading event (mdn#1010) chore(deps): update dependency prettier to v1.13.7 (mdn#1006) fix(address): add name to the provided address (mdn#1004) chore(community): add @Arkangus as contributor (mdn#1002) Correct "expected output" mistake (mdn#1000) fix(performance): send post to kuma for custom ie-load-event-end metric (mdn#1001) chore(deps): update jest monorepo to v23.2.0 (mdn#993) ...
Adds color-adjust interactive example.