Improvements/pending test rebased #170

zgorizzo69 · 2022-06-01T10:26:04Z

this branch includes
#166 fix/improvements
#169 calculate-views and pending-tests

This reverts commit 7b527e4.

- an index is added when we want to store additional information related to... - that variable on the contract. - for example, it is required in case of an airdrop to store bool mapping against... - the index to check if a claim was made.

- add InitSeason event - replaced isSeasonLive with hasSeasonEnded

This reverts commit 561f3e0.

- High reduction of gas in vault deployment (66071 gas or 5.819% decrease)

- `meTokenInfo.migration != address(0)` can be removed as msg.sender cannot be 0 address - `meTokenInfo.migration != address(this)` can be removed as ... - SingleAssetVault cannot call `startMigration`.

parv3213 · 2022-06-01T10:57:21Z

@cartercarlson @zgorizzo69 please review 87e3cca.

parv3213

Liquidity mining code

contracts/facets/OwnershipFacet.sol

contracts/libs/LibAppStorage.sol

contracts/mocks/LibAppStorageMock.sol

scripts/deploy.ts

parv3213

Liquidity mining code

Carter Carlson and others added 30 commits May 19, 2022 14:16

feat: start of LiquidityMiningFacet

c962f11

feat: diamond usage

32e1eaa

refactor: views

1c4519f

feat: liquidityMiningController

9c70701

chore: remove unused funcs, fill out refreshPool()

25bff33

fix: most state variables to diamond storage

92861ba

fix: all state to appStorage

3b61b46

fix: semantics

5bed032

fix: change me type to IERC20

0467f49

fix(LMF): require reason

a7db828

fix(LMF): add TODO for precision check

de43c7f

perf(LMF): clear calculation

3ce2d11

fix: all state to appStorage

0a1875b

fix: change me type to IERC20

b5c6225

perf: improvements

f7eedb2

fix: replace claimRewardExact with modifed claimReward

30d9a2e

fix: proper function arrangement

c8632e7

perf: precise imports

44dcba5

perf: remove unnecessary constructor

aabae5b

feat: add few functions

18e5d6b

feat: add setter and getter

78a6749

test(LiquidityMining): create and add few tests

944bb8a

chore: remove unnecessary TODOs

a129b83

test: unexpected result

b161842

fix(rentrency): add to local storage

ca28113

fix(liquidity): add init

1283517

Revert "test: unexpected result"

8228e4d

This reverts commit 7b527e4.

test(LMF): add tests related to initSeason

efc68c5

feat: changes in initSeason

0a69908

- add InitSeason event - replaced isSeasonLive with hasSeasonEnded

parv3213 and others added 11 commits June 1, 2022 11:48

Revert "fix(LibMeta): comment unsed functions"

83e69ec

This reverts commit 561f3e0.

feat(LibCurve): add require string

aba79b9

test(curvesTestsHelper): add test for edge cases

3c37c53

fix(SameAssetTM): fix require message

81f6bd4

test(migrations): add pending tests

59a0c47

feat: optimise contracts and add tests

bd695a6

- High reduction of gas in vault deployment (66071 gas or 5.819% decrease)

fix(Vault): rearrange public function

cb91a70

fix(SingleAssetVault): remove unnecessary conditions

bed3962

- `meTokenInfo.migration != address(0)` can be removed as msg.sender cannot be 0 address - `meTokenInfo.migration != address(this)` can be removed as ... - SingleAssetVault cannot call `startMigration`.

test(LibCurve): add pending tests

91e3fb1

fix(init): diamondInit require diamondController

486f51a

fix(LibCurve): logic improvement

87e3cca

parv3213 requested changes Jun 1, 2022

View reviewed changes