Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements/pending test rebased #170

Merged
merged 72 commits into from
Jun 1, 2022
Merged

Improvements/pending test rebased #170

merged 72 commits into from
Jun 1, 2022

Commits on May 19, 2022

  1. feat: start of LiquidityMiningFacet

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c962f11 View commit details
    Browse the repository at this point in the history

  2. feat: diamond usage

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    32e1eaa View commit details
    Browse the repository at this point in the history

  3. refactor: views

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1c4519f View commit details
    Browse the repository at this point in the history

  4. feat: liquidityMiningController

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    9c70701 View commit details
    Browse the repository at this point in the history

  5. chore: remove unused funcs, fill out refreshPool()

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    25bff33 View commit details
    Browse the repository at this point in the history

  6. fix: most state variables to diamond storage

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    92861ba View commit details
    Browse the repository at this point in the history

  7. fix: all state to appStorage

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3b61b46 View commit details
    Browse the repository at this point in the history

  8. fix: semantics

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    5bed032 View commit details
    Browse the repository at this point in the history

  9. fix: change me type to IERC20

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0467f49 View commit details
    Browse the repository at this point in the history

  10. fix(LMF): require reason

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    a7db828 View commit details
    Browse the repository at this point in the history

  11. fix(LMF): add TODO for precision check

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    de43c7f View commit details
    Browse the repository at this point in the history

  12. perf(LMF): clear calculation

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    3ce2d11 View commit details
    Browse the repository at this point in the history

  13. fix: all state to appStorage

    @zgorizzo69
    Carter Carlson authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0a1875b View commit details
    Browse the repository at this point in the history

  14. fix: change me type to IERC20

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    b5c6225 View commit details
    Browse the repository at this point in the history

  15. perf: improvements

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    f7eedb2 View commit details
    Browse the repository at this point in the history

  16. fix: replace claimRewardExact with modifed claimReward

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    30d9a2e View commit details
    Browse the repository at this point in the history

  17. fix: proper function arrangement

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c8632e7 View commit details
    Browse the repository at this point in the history

  18. perf: precise imports

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    44dcba5 View commit details
    Browse the repository at this point in the history

  19. perf: remove unnecessary constructor

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    aabae5b View commit details
    Browse the repository at this point in the history

  20. feat: add few functions

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    18e5d6b View commit details
    Browse the repository at this point in the history

  21. feat: add setter and getter

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    78a6749 View commit details
    Browse the repository at this point in the history

  22. test(LiquidityMining): create and add few tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    944bb8a View commit details
    Browse the repository at this point in the history

  23. chore: remove unnecessary TODOs

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    a129b83 View commit details
    Browse the repository at this point in the history

  24. test: unexpected result

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    b161842 View commit details
    Browse the repository at this point in the history

  25. fix(rentrency): add to local storage

    @zgorizzo69
    zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ca28113 View commit details
    Browse the repository at this point in the history

  26. fix(liquidity): add init

    @zgorizzo69
    zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1283517 View commit details
    Browse the repository at this point in the history

  27. Revert "test: unexpected result" 

    This reverts commit 7b527e4.
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    8228e4d View commit details
    Browse the repository at this point in the history

  28. feat: remove non-essential index from merkle node 

    - an index is added when we want to store additional information related to...
- that variable on the contract.
- for example, it is required in case of an airdrop to store bool mapping against...
- the index to check if a claim was made.
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    679793e View commit details
    Browse the repository at this point in the history

  29. test(LMF): add tests related to initSeason

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    efc68c5 View commit details
    Browse the repository at this point in the history

  30. feat: changes in initSeason 

    - add InitSeason event
- replaced isSeasonLive with hasSeasonEnded
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0a69908 View commit details
    Browse the repository at this point in the history

  31. fix: comment off addToRewardsAllocation due to improper implementation

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    bf0bc3d View commit details
    Browse the repository at this point in the history

  32. fix: did some renaming and add TODOs

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    75cdd30 View commit details
    Browse the repository at this point in the history

  33. fix: did some renaming and add TODOs

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    4618948 View commit details
    Browse the repository at this point in the history

  34. test(LMF): test recoverERC20

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    c5d2381 View commit details
    Browse the repository at this point in the history

  35. feat: minor improvement

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    989d3a5 View commit details
    Browse the repository at this point in the history

  36. test(LMF): incremental tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    6ee9680 View commit details
    Browse the repository at this point in the history

  37. fix: improvements

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    4134ff3 View commit details
    Browse the repository at this point in the history

  38. test: add MerkleTree

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    1df2859 View commit details
    Browse the repository at this point in the history

  39. feat: update getPoolInfo to return user specific details 

    - add and remove some comments
- some optimisations
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    7af0f8a View commit details
    Browse the repository at this point in the history

  40. test(LMF): complete stake tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    56c7fd2 View commit details
    Browse the repository at this point in the history

  41. test(LMF): complete withdraw tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    41ae09a View commit details
    Browse the repository at this point in the history

  42. fix(diamond): reentrancy and tests fixed

    @zgorizzo69
    zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    5a92739 View commit details
    Browse the repository at this point in the history

  43. fix(liquidity mining): separate storage

    @zgorizzo69
    zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0c64994 View commit details
    Browse the repository at this point in the history

  44. fix(test): fix tests and remove todo

    @zgorizzo69
    zgorizzo69 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    0cd472e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. fix(test): set correct state at end of test

    @zgorizzo69
    zgorizzo69 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    ee40626 View commit details
    Browse the repository at this point in the history

  2. fix(test): fixing todos

    @zgorizzo69
    zgorizzo69 committed May 20, 2022
    Configuration menu
    Copy the full SHA
    c1c6ba3 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. fix(migration): add test for migration swap triggered by burn

    @zgorizzo69
    zgorizzo69 committed May 26, 2022
    Configuration menu
    Copy the full SHA
    d2097fc View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. fix(init): remove unecessary import

    @zgorizzo69
    zgorizzo69 committed May 30, 2022
    Configuration menu
    Copy the full SHA
    9391d06 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. fix(remove): clean liquidity mining

    @zgorizzo69
    zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    507c517 View commit details
    Browse the repository at this point in the history

  2. feat: calculate views

    @pegahcarter @zgorizzo69
    pegahcarter authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    78ed499 View commit details
    Browse the repository at this point in the history

  3. fix: function calls

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    c107f66 View commit details
    Browse the repository at this point in the history

  4. test: failing view test

    @pegahcarter @zgorizzo69
    pegahcarter authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9a9bbaa View commit details
    Browse the repository at this point in the history

  5. fix(test): foundry calculate

    @zgorizzo69
    zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d058ec7 View commit details
    Browse the repository at this point in the history

  6. test(FoundryFacet): add test for calculateAssetsReturned

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    efb542a View commit details
    Browse the repository at this point in the history

  7. test(Hub): add missing testcase

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    d9e6673 View commit details
    Browse the repository at this point in the history

  8. fix: comment unsued code

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ffa4f75 View commit details
    Browse the repository at this point in the history

  9. test(MigrationRegistry): add tests 

    - remove similar tests from UniswapSingleTransfer.ts
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a45cf55 View commit details
    Browse the repository at this point in the history

  10. fix(HubFacet): call library function

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f90d3b8 View commit details
    Browse the repository at this point in the history

  11. fix(LibMeta): comment unsed functions

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e8cfb32 View commit details
    Browse the repository at this point in the history

  12. Revert "fix(LibMeta): comment unsed functions" 

    This reverts commit 561f3e0.
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    83e69ec View commit details
    Browse the repository at this point in the history

  13. feat(LibCurve): add require string

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    aba79b9 View commit details
    Browse the repository at this point in the history

  14. test(curvesTestsHelper): add test for edge cases

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3c37c53 View commit details
    Browse the repository at this point in the history

  15. fix(SameAssetTM): fix require message

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    81f6bd4 View commit details
    Browse the repository at this point in the history

  16. test(migrations): add pending tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    59a0c47 View commit details
    Browse the repository at this point in the history

  17. feat: optimise contracts and add tests 

    - High reduction of gas in vault deployment (66071 gas or 5.819% decrease)
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    bd695a6 View commit details
    Browse the repository at this point in the history

  18. fix(Vault): rearrange public function

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    cb91a70 View commit details
    Browse the repository at this point in the history

  19. fix(SingleAssetVault): remove unnecessary conditions 

    - `meTokenInfo.migration != address(0)` can be removed as msg.sender cannot be 0 address
- `meTokenInfo.migration != address(this)` can be removed as ...
- SingleAssetVault cannot call `startMigration`.
    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    bed3962 View commit details
    Browse the repository at this point in the history

  20. test(LibCurve): add pending tests

    @parv3213 @zgorizzo69
    parv3213 authored and zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    91e3fb1 View commit details
    Browse the repository at this point in the history

  21. fix(init): diamondInit require diamondController

    @zgorizzo69
    zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    486f51a View commit details
    Browse the repository at this point in the history

  22. fix(LibCurve): logic improvement

    @parv3213
    parv3213 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    87e3cca View commit details
    Browse the repository at this point in the history

  23. fix(facet): remove liquidity mining controller

    @zgorizzo69
    zgorizzo69 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    3147d9e View commit details
    Browse the repository at this point in the history

  24. chore(facet): rmv old LM vars

    @pegahcarter
    pegahcarter committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0d589e8 View commit details
    Browse the repository at this point in the history