0.4.0 Release

[lirantal]

This is a list of all PRs and Issues that we want fixed and merged to 0.4.0 branch before we release.

General Features

• Admin module support Admin module #615 Admin module #676
• [Nice to Have] add backend support for Article voting add backend support for Article voting #552 (RESOLVED as not part of 0.4.0)
• Page not found handler not working in 0.4.0 #501 Handle 404 errors at Express backend and at Angular frontend #501 Handle 404 errors at Express backend and at Angular frontend #566

Minor Cleanups

• Task Enhancements Task Enhancements #666
• Move Logo, Favicon, and Livereload to Config Move Logo, Favicon, and Livereload to Config #664 Move livereload, image, and favicon to config #685
• Set base title from default config. Set base title from default config. #662
• Added uploads folder under module/users/client/img/profile so that us… Add Grunt task to make sure uploads directory exists #731 (needs a new PR)
• Enable redirection to previous page after login Enable redirection to previous page after login #487
• Make emails unique Make emails unique #439
• removed /#! in user controllers removed /#! in user controllers #587 (needs a new PR) Feature/clean angular hashbang urls #693

Tests

• Server Side Test Coverage Server Side Test Coverage #569 (needs a new PR)
• Client side test coverage Client side test coverage #663

Documentation

• Overview, Troubleshooting, and Permalinks Overview, Troubleshooting, and Permalinks #652
• Removed the s at 'express routes' in the menu to match the usage of t… Removed the s at 'express routes' in the menu to match the usage of t… #595

[codydaig]

#439 takes care of some of the changes from #587

[lirantal]

@codydaig are you sure? they look totally unrelated.

[codydaig]

If you look on and around this line: @igorauad made some of those changes. But it does not cover all the places that #! needed to be removed that #587 points out.
https://github.com/meanjs/mean/pull/439/files#diff-6586a849345903e73352845be92306cfL87

[simison]

I'd leave ngBestPractices (#636) PL out and do it more thoroughly for 0.5.0 (it's related to #490 style guide). @rhutchison thoughts?

[igorauad]

@codydaig, thanks for pointing. @lirantal #587 can be merged first, then I update #439 accordingly.

[ilanbiala]

Style should follow in 0.4.1 or even 0.5.0 depending on how big of a change it is, but since it doesn't change functionality we should be able to do it anytime.

[ilanbiala]

@lirantal https://github.com/meanjs/mean/blob/0.4.0/modules/chat/tests/client/chat.client.controller.tests.js is a little bit of an issue, no?

[ravisuhag]

We should also get rid for either Gulp or Grunt. I would say Grunt as no doubt Gulp is better choice for performance.

[lirantal]

@ravisuhag Gulp is maybe an option for 0.5.0, for 0.4.0 we'll stick with grunt.
@ilanbiala @rhutchison who volunteers to add some tests to https://github.com/meanjs/mean/blob/0.4.0/modules/chat/tests/client/chat.client.controller.tests.js ?

[cdriscol]

@lirantal, @ilanbiala - I added those chat tests as part of #728. That PR also covers the second bullet in Tests above.

[lirantal]

Hi everyone,

We'd like to aggressively push 0.4.0 out before it becomes a monster :-)
We appreciate all the great PRs but with more PRs we delay time because we are all opinionated people (and good that we are), and we're all quite busy and PRs need to be reviewed extensively.

@ilanbiala suggested closing 0.4.0 out by Thursday (tomorrow) so we can do all the release logistics (merging, etc) and this means we need to close only 'core' 0.4.0 and only important PRs for 0.4.0. The remaining 'nice to have' enhancements we will mark as 0.4.x so we can review and possibly merge them as 0.4.1 and so on soon after 0.4.0 is released.

@ilanbiala @codydaig @simison @rhutchison @igorauad @trainerbill @mleanos @cdriscol

[codydaig]

@lirantal @ilanbiala Sounds good to me!

[simison]

👍 absolutely.

[ilanbiala]

@lirantal just waiting for server side tests if we want to include that in 0.4.0 instead of releasing incrementally in 0.4.x.

[lirantal]

since it's a change to the core server.js and grunt I want to push that in a couple of hours for your review.

[mleanos]

+1 Sounds great.

[taninme]

any update on release date ? thanks :)

[lirantal]

@taninme tomorrow/upcoming week.

[taninme]

👍

[lirantal]

before we go ahead with the final 0.4.0 release, if you want to raise a PR for discussion which must be included in 0.4.0 now is the time.

[lirantal]

@ilanbiala looks like I'm not going to make it for the refactoring of the core server.js as I hoped so if we might want to continue without it if I won't ping anything different in the morning.

[ilanbiala]

Ok. If that's the case, we'll release tomorrow morning and we can start taking care of 0.4.1.

[lirantal]

Cool, I took the day off tomorrow so we can do it on gitter, I'll probably have my coffee ready by 8:30am (GMT+3)

[codydaig]

So that's 10:30 PST?

[lirantal]

09:30PM

[codydaig]

Whoops. Off by 1 hour.

[cdriscol]

👍 - awesome!

[taninme]

released ? missed the party ?

[lirantal]

not yet, 2 more PRs to close, mine and @rhutchison and we're done

[ravitejawedelez]

any way to know the schedule for release?
waiting for the admin dashboard..

[lirantal]

0.4.0 released now and merged into master branch.
You can also find the 0.4.0 tag here: https://github.com/meanjs/mean/releases/tag/v0.4.0

[lirantal]

Thanks everyone for your hard work, couldn't do it with you!

[igorauad]

Congrats everyone! Very good work.

[mleanos]

👍 Everyone here is awesome! Didn't have any merge conflicts from 0.4.0 to master :) Thanks @codydaig for prepping that.

[rbecheras]

Great! congratulations guys ! 👏

[vaucouleur]

Congrats. Thanks for the excellent work !

[quanganh206]

Thansk and Congrats !

[taninme]

Congrats all and quick question ..did you add the admin dashboard to 0.4 ?

[lirantal]

@taninme yes, it's there.

[simison]

Excellent! Nice to come back down from the mountains and there's a new release waiting. Thanks everyone who worked on this. It's a massive pile of great commits!

[lirantal]

@simison I'm not going to greet you welcome back until I see some PRs from you :-)
j/k, nice to have you around again!

[lirantal]

closing this issue since we already released 0.4.0, you're welcome to continue commenting on any 0.4.0 matters though.