This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Feature/clean angular hashbang urls #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igorauad is this ok? |
|
Yes, @lirantal . The only one left that I found is in the articles end-to-end tests: |
|
@igorauad thanks, I also found another instance of that so I updated this PR. |
Resolved 0.4.0 related conflicts: modules/users/server/controllers/users/users.authentication.server.controller.js
lirantal
force-pushed
the
feature/clean_angular_hashbang_urls
branch
from
405d155 to
de3b890
Compare
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Jul 24, 2015
…urls Feature/clean angular hashbang urls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #587 to clean up the URLs