Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Server Side Test Coverage #569

Closed
wants to merge 1 commit into from
Closed

Conversation

Mangesh-P
Copy link

No description provided.

@Mangesh-P Mangesh-P changed the title Included all the changes. Server Side Test Coverage May 22, 2015
@sielay
Copy link

sielay commented Jun 18, 2015

It seem to work, but in fact it runs only server.js and ends. In report you see nothing really and it fails on trying to load first mongoose model.

@ilanbiala
Copy link
Member

@MangeshMp the indentation and all that has to be changed back and the PR has to be rebased.

@lirantal
Copy link
Member

@MangeshMp looks like a great addition, would you like to re-submit this PR by cleaning up the indentation and solving whatever conflicts there are?

@lirantal lirantal mentioned this pull request Jul 20, 2015
14 tasks
@ilanbiala
Copy link
Member

@Mangeshpimpalkar can you tidy this up in a new PR?

@ilanbiala
Copy link
Member

@lirantal judging by when this PR was created, I'm guessing it's quite a bit out of date. I think we should just add tests as we go instead of holding off on 0.4.0 for this when it's going to require lots of changes. If you agree just close the PR and add a note to 0.4.x release planning.

@lirantal
Copy link
Member

@ilanbiala I have a local branch to work on this issue exactly, it's not very simple and will need a refactor to the main server.js file, maybe I'll be able to push something in later today for you to review.

@lirantal
Copy link
Member

Thanks @Mangeshpimpalkar!
I've implemented the same at #811 please go and review

@lirantal lirantal closed this Aug 15, 2015
@lirantal lirantal added this to the 0.4.x milestone Sep 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants