Added short Gulp Section to Intro #1006
Conversation
| $ npm install -g grunt-cli | ||
| ``` | ||
|
|
||
| * Gulp - You may use Gulp for Live Reload, Linting, and SASS or LESS. |
There was a problem hiding this comment.
We should make sure that it is explicitly says that Gulp right now is optional, not mandatory.
There was a problem hiding this comment.
Agreed. I will make that more clear.
|
|
||
| ```bash | ||
| $ gulp test | ||
| ``` |
There was a problem hiding this comment.
do we also want to add the following to indicate you can test each tier?
# run server tests
gulp test:server
# run client tests
gulp test:client
# run e2e tests
gulp test:e2eThere was a problem hiding this comment.
@jloveland I like that idea. I will include your addition.
|
@Zeldar Thanks for the contribution! If you can adjust the line comments above, and move the troubleshooting out of this PR and into a PR against the gh-pages (documentation) branch, it should be good to go! |
|
@codydaig now we just have to move the troubleshooting out of this PR right? |
|
@ilanbiala @Zeldar Correct me if I am wrong, but looks like the troubleshooting got removed. If so I think it's ready. |
|
Yep, but it still needs to be added to gh-pages in a separate PR. Let's get this squashed and merged? |
|
This shouldn't hold 0.4.2 so I set it to 0.5.0 |
|
Just to clarify: @Zeldar we'll still merge this whenever it comes around, so if it comes before 0.4.2 releases, great. If not, that's fine too, but we still want to merge this in. |
|
@ilanbiala Yes, Troubleshooting was removed. Do you want the addition of the Troubleshooting section pushed to this commit before squashing, or do you want me to create a new issue for Troubleshooting and push the Gulp Troubleshooting as a different commit? Just wanted to clarify, but can have that finished this evening. |
|
@Zeldar The troubleshooting has to be to a separate PR since it will be against the gh-pages branch to have on the website / documentation. |
|
@codydaig #1037 PR for gh-pages Gulp documentation and troubleshooting. I have the same thing I wrote into the HTML in a TROUBLESHOOTING.md as well on my local machine, but noticed the TROUBLESHOOTING.md was blank. Is there plans for that document, or is it part of the Jekyll process? Do you need anything else from me on this PR? Thank you for the help in getting sorted out. |
|
@Zeldar There aren't any plans for a TROUBLESHOOTING.md document. |
|
LGTM |
|
@ilanbiala We can't realistically start enforcing it until the changelog.md doc gets merged in. I'm starting too on my commits but I don't think we should enforce until 0.4.2 is released. All commits for 0.5.0 should follow the format. |
|
Yeah makes sense. |
|
@Zeldar Can you squash down to 1 commit? Ping me once it's squashed and I'll merge. |
Added short Gulp Section to Intro Added Short Gulp Section to Intro
|
@codydaig I believe this is ready. Thank you! |
|
@Zeldar Yup! Thanks a bunch! LGTM |
Added short Gulp Section to Intro
#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x
Issue #743 - Adding Gulp.
The basics have been added, but I will continue to add onto this throughout the week for another commit in the short future.