Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x #1037

Merged
merged 1 commit into from
Nov 6, 2015
Merged

#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x #1037

merged 1 commit into from
Nov 6, 2015

Conversation

dprea
Copy link
Contributor

@dprea dprea commented Oct 30, 2015

Gulp Setup and Troubleshooting sections added to the 0.4.x docs.

@@ -40,6 +40,11 @@
<li><pre>$ grunt build</pre></li>
</ul>
</li>
<li>Run the Gulp Build task to build the optimized JavaScript and CSS files (If you chose Gulp instead of Grunt)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave this out of the deployment sections until we switch over to gulp completely.

@lirantal Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codydaig I'm actually going to try to put some work into Gulp this weekend, so let's hold off on removing it if I can make reach parity between Gulp and Grunt.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilanbiala Here it should be one or the other. Since they are deploying to a service, it should be what we think is the most reliable. Currently that is grunt. Now, I'd love to eliminate grunt in 0.5 and have everything run with gulp, and in that case we can switch the documentation over to reflect the new gulp set-up. Having both side by side in a deployment walk through is slightly confusing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True that we can't remove Grunt until 0.5, so let's go with your suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codydaig I'm removing this line and sending a new commit now. Will wait for 0.5 to add.

@codydaig
Copy link
Member

@Zeldar Besides the couple line comments above, looks good.

THANKS A BUNCH! :-D

Removed Obvious Node Install Warning

Removed Gulp Build from cloud-foundry.html to be added in 0.5

Added and Cleaned Up Gulp Setup and Troubleshooting to docs/0.4.x
@dprea
Copy link
Contributor Author

dprea commented Oct 31, 2015

@codydaig Did that squash work?

@codydaig
Copy link
Member

codydaig commented Nov 6, 2015

@Zeldar Yes the squash worked. Thanks!

codydaig added a commit that referenced this pull request Nov 6, 2015
#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x
@codydaig codydaig merged commit c5fe1de into meanjs:gh-pages Nov 6, 2015
@ilanbiala ilanbiala added this to the 0.4.x milestone Nov 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants