-
Notifications
You must be signed in to change notification settings - Fork 2k
#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x #1037
Conversation
@@ -40,6 +40,11 @@ | |||
<li><pre>$ grunt build</pre></li> | |||
</ul> | |||
</li> | |||
<li>Run the Gulp Build task to build the optimized JavaScript and CSS files (If you chose Gulp instead of Grunt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to leave this out of the deployment sections until we switch over to gulp completely.
@lirantal Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codydaig I'm actually going to try to put some work into Gulp this weekend, so let's hold off on removing it if I can make reach parity between Gulp and Grunt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilanbiala Here it should be one or the other. Since they are deploying to a service, it should be what we think is the most reliable. Currently that is grunt. Now, I'd love to eliminate grunt in 0.5 and have everything run with gulp, and in that case we can switch the documentation over to reflect the new gulp set-up. Having both side by side in a deployment walk through is slightly confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True that we can't remove Grunt until 0.5, so let's go with your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codydaig I'm removing this line and sending a new commit now. Will wait for 0.5 to add.
@Zeldar Besides the couple line comments above, looks good. THANKS A BUNCH! :-D |
Removed Obvious Node Install Warning Removed Gulp Build from cloud-foundry.html to be added in 0.5 Added and Cleaned Up Gulp Setup and Troubleshooting to docs/0.4.x
@codydaig Did that squash work? |
@Zeldar Yes the squash worked. Thanks! |
#1006 Added Gulp Setup and Troubleshooting to docs/0.4.x
Gulp Setup and Troubleshooting sections added to the 0.4.x docs.