Skip to content
This repository was archived by the owner on Aug 30, 2021. It is now read-only.

fix(core): Remove the <base> tag. #1230

Closed
wants to merge 1 commit into from

Conversation

0x24a537r9
Copy link
Contributor

Fixes #1224. Everything looks good in the browser and server/e2e tests, but unfortunately the unit tests are broken, and I'll probably need some guidance from someone more familiar with Angular/Karma.

@lirantal lirantal self-assigned this Feb 22, 2016
@lirantal lirantal added this to the 0.5.0 milestone Feb 22, 2016
@lirantal lirantal closed this Mar 29, 2016
@lirantal lirantal reopened this Mar 29, 2016
@lirantal
Copy link
Member

@meanjs/contributors any say?

@ilanbiala
Copy link
Member

I remember using SVG and Angular, but I don't think I had to remove the base tag. Sadly I can't access that code anymore, so I can't tell you for sure how I solved that issue. @0x24a537r9 did you find an authoritative Angular contributor/issue saying that the base tag cannot be used?

@0x24a537r9
Copy link
Contributor Author

@ilanbiala please see my explanations in #1224 for why the base tag will break specific SVG features (not all SVGs or Angular). I provide a number of sources detailing exactly when and why the <base> tag is problematic.

Unfortunately due to wedding planning and performance assessments at work, I haven't had any time to continue looking into the unit test issue I was running into described in #1224. That said, I really wasn't making any progress anyway, so this might need to be forked and taken up by someone more familiar with Angular testing with Karma.

@lirantal
Copy link
Member

lirantal commented Jul 8, 2016

@0x24a537r9 can you take another look at this PR?

@coveralls
Copy link

coveralls commented Jul 23, 2016

Coverage Status

Coverage remained the same at 70.628% when pulling 428c589 on 0x24a537r9:remove-base-tag into 35d7501 on meanjs:master.

Wuntenn pushed a commit to Wuntenn/mean that referenced this pull request Jul 24, 2016
@lirantal
Copy link
Member

We can really save this PR if someone can help fix the Karma tests...
cc @0x24a537r9 @seanhussey @hyperreality @mleanos

@lirantal lirantal closed this Oct 6, 2016
lirantal added a commit that referenced this pull request Oct 12, 2016
fix(core): Remove the <base> tag (continues #1230)
Merge pull request #1544 from mleanos/remove-base-tag
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants