-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(core): Remove the <base> tag (continues #1230) #1544
Conversation
Coverage remained the same at 73.036% when pulling a43700bbcb50821914671cff615dc11b83a17afc on mleanos:remove-base-tag into 73a7c2c on meanjs:master. |
@mleanos thanks. |
@lirantal Yes. We can close to the other. |
Ok I'll close the older one. Can you rebase your branch here with the latest changes? |
Updated tests to account for new "/" prefix in the path.
Fixes the client-side tests after the removal of the <base/> tag from the main layout. These fixes aren't ideal. At the moment, they will suffice. This comment (angular-ui/ui-router#212 (comment)), among others in that issue, led me to choose this method as the fix to avoid having to change any other core code.
a43700b
to
99e5803
Compare
@lirantal This has been rebased. |
It's a big change through a lot of files so I want to test it a bit locally to confirm it's ok not breaking anything first and then I'll merge. |
@lirantal When you merge, don't squash. I noticed with the other PR that I took over, the commits from the original contributor were squashed into mine; thus, the original author's commits aren't reflected in the history. If you'd prefer, I can squash my commits down to 1 so there would be only two going in with this merge. Either way, it's not a big deal to me but we should try to at least keep @0x24a537r9's commits. |
Of course, no problems. |
Seems to work great, thanks @mleanos and @0x24a537r9 for all the help! |
Looks like removing the tag also broke the ability to add a URL in the config/assets/default or production files. Normally you could add a URL as a css dependency (lets say to a google font) but now it appends localhost to the beginning of the URL |
@0x24a537r9
This is a continuation of #1230, in an attempt to finalize the changes by fixing the broken tests.
NOTE: The fixes to the client-side tests aren't ideal. At the moment, they will suffice. This comment,
among others in that issue, led me to choose this method as the fix to
avoid having to change any core code.