-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
@ilanbiala per your request... |
Doesn't this go against HTML validation standards? data- is supposed to be included anytime you have a custom attribute not defined by W3C. I like the data- |
@trainerbill The angular style guide that I personally refer back too (and I think it's been mentioned before in a previous issue) never even references using data-. I'm not familiar with how it plans into validation standards though. |
|
Personally, Im going to keep |
yeah I'm not sure why we removed it, need to wait for Ilan's response here |
Data- was just to comply with XHTML IIRC. HTML5 allows all kinds of custom attributes if I'm not mistaken and syntax highlighters will work with either one. data- also just adds extra characters and makes everything longer. Anyway Some Angular HTML sometimes doesn't pass through W3C (and we know that isn't what necessarily makes a page better), so I don't see why we should try to conform more towards it. |
HTML5 is also strict about the attributes type and it would prefer a data-* over plain custom. Unless there's a strong argument in removing data-* I think we can close this PR. |
@lirantal I don't really care, but we shouldn't be inconsistent and I see no reason to do |
I haven't seen a strong argument towards removing |
1554884
to
7e022ab
Compare
7e022ab
to
3bf07fe
Compare
LGTM :-D |
Remove 'data' prefix from attributes
Remove the 'data' prefix from custom attributes.