0.4.1 Release

[rhutchison]

We are tracking towards the release of 0.4.1. This thread is to discuss what needs to be finalized before we can cut the release. If there are any PRs or open issues that should be added to the list, please comment below.

General

• client-side form validation with ng-messages. #759 [Enhancement] client-side validation @ilanbiala
• Unauthorized client side routing #796 [Enhancement] http interceptor to handle unauthorized requests @ilanbiala
• [Bug] Previous State (History) #843 [Bug] previous state history @lirantal
• Adding coverage report for server-side tests using istanbul #811 [Enhancement] code coverage report @lirantal
• Correct <br /> Tags and set Title #836(Correct <br /> Tags and set Title #813/Correct <br /> Tags and set Title #814) XHTML compliant e-mail templates @lirantal
• [fix] Was storing a 6 char password in plain text [fixes #829] #830 [Bug] 6 character pw stored as plain text @lirantal
• Gulp task enhancements - template cache #853 [Enhancement] Template cache @ilanbiala
• Remove 'data' prefix from attributes #774 Remove data attribute prefix @ilanbiala
• Created Contributing.md #815 CONTRIBUTING.md @lirantal
• Facebook authentication #842 [Bug/Enhancement] Facebook Authentication @lirantal
• Renamed files using convention verb-object.client... #850 naming convention @lirantal
• Add Deploy to Bluemix button to documentation #868 Add Deploy to Bluemix button to documentation
• [WIP] ngBestPractices #636 Best Practices - Style Guide @ilanbiala

Articles

• Article route / controller refactor #800 route refactoring @ilanbiala
• Articles admin feature #807 [Enhancement] admin @ilanbiala
  • rebase after Article route / controller refactor #800 is merged

[ilanbiala]

I don't think the style guide is making it into 0.4.1. Other than that, I'm fine with the rest of the list.

[simison]

Nice! What do you think about including #639 ([WIP] Design/UX Enhancements)?

[simison]

@ilanbiala do you recon the style guide could do pre 0.5.0? I could start helping with it within a week or so (holidays over, on the way home).

Actually #800 covers some of the style guide aspects already.

[rhutchison]

@ilanbiala other than it requires work, what reasons would you have against setting styleguide as a stretch goal?

[mleanos]

@rhutchison I think the order which the Articles PR's should be merged is important #831

I think development will go a lot fast once we get the Styling guide implemented. We'd end up having to re-do work if we waited.. If there's good reason to wait, then I say push it till after 0.5.0 or as a requirement for 0.5.0.

[mleanos]

@rhutchison I'm fine with #800 going in before #807 since it requires a bit more discussion.

[lirantal]

Thanks guys for summing this up.
Can you please add the assigned person (me/Ilan) per issue so we can easily navigate to relevant items?

@ilanbiala you're welcome to add/remove items.
@rhutchison I'm overall in agreement with @ilanbiala about not pushing too big items such as the UX work. As you can see we're already doing much better in terms of agile and fast releases so it will be sure to catch up in 0.4.2 or something. The other reason would be to also let the changes quick in the dev cycle, meaning I would want to see UX story merged soon after 0.4.1 is out so we can "test drive" it for a little while on master before 0.4.2 is out.

[rhutchison]

@lirantal I never had the UX story in this list, I would like to see effort towards ngBestPractices though. The UX can come in 0.4.3.

BTW, good work keeping the project moving - much improved

Also, I don't think non-contributors can manage/assign issues.

[lirantal]

Thanks, we're all doing a great job here, definitely feels like we should meet for some beer somehow ;)

With regards to the issues assigned, I meant to update them in the bullets list above so it's easier to see whose assigned to one in that list you've put up there.

[ilanbiala]

Sorry guys, but I have orientation week until Friday, so I'll be slow to get to these issues, though I will try my best. @lirantal if you want to take the lead on anything, I'm fine with that.

[lirantal]

OK then. I'll sync with the guys on each issue to move it further.
On Aug 24, 2015 6:43 AM, "Ilan Biala" notifications@github.com wrote:

Sorry guys, but I have orientation week until Friday, so I'll be slow to
get to these issues, though I will try my best. @lirantal
https://github.com/lirantal if you want to take the lead on anything,
I'm fine with that.

—
Reply to this email directly or view it on GitHub
#833 (comment).

[ilanbiala]

Rearranged some issues so the 0.4.1 milestone contains all of the above issues/PRs. Let's try to release this in the next week and push whatever else can't get done into 0.4.2 or 0.4.x or 0.5.0.

[rhutchison]

Other than #811 is there anything else left open? @lirantal what is the status on #811?

I would recommend we cut 0.4.1 and move the articles PRs to 0.4.2.

Also starting with 0.4.2, all PRs with angular changes should follow angular-styleguide - if a file is touched, it should be updated. I will put a larger effort to converting the modules.

[lirantal]

Hey guys,
Just merged #811.

@ilanbiala the rest are yours, are we going to merge them for 0.4.1?

[rhutchison]

@ilanbiala @lirantal please ship this as 0.4.1 and create the proper release tag. We will start working on 0.4.2

[codydaig]

👍

[ilanbiala]

@lirantal yes 0.4.1 is good to go. The rest are going into 0.4.2.

[mleanos]

👍 Nice. Great job everyone!

[ilanbiala]

@lirantal do you want to create the release and I'll work on the next PRs?

[ilanbiala]

Added #868 but it is already merged, so it should be good to go.

[lirantal]

@ilanbiala sure thing.

[lirantal]

@ilanbiala so basically except from tagging master branch as 0.4.1 there isn't anything else to do, right? we don't have an 0.4.1 branch like we had before with 0.4.0 so I don't see any merges required.

Tag created: https://github.com/meanjs/mean/releases/tag/v0.4.1

[ilanbiala]

Only thing maybe is a changelog. @rhutchison what's the integration branch for?

[lirantal]

Merged related PRs #877 and #876 to update the version number to 0.4.1

[rhutchison]

@ilanbiala it was to help test a bunch of related PRs. It's removed now.

[rhutchison]

Thanks @lirantal. Please recreate the tag, now that #876 is merged and close this issue when you are done.

@ilanbiala @lirantal We should introduce CHANGELOG.md in next release. Does anyone have access to modify http://meanjs.org/changelog.html?

[lirantal]

Done.

[codydaig]

@rhutchison Chanelog.html is just in the gh_pages branch.

[ilanbiala]

@rhutchison I'd like to start the CHANGELOG.md from 0.4 as the "initial release" so we don't have to compare it against 0.3. We can talk about this in #881.

@lirantal I think you can close this issue and the 0.4.1 milestone.

[lirantal]

I think we can close this can move the discussion to #881 and the 0.4.2 issue