Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Correct <br /> Tags and set Title #813

Closed
wants to merge 1 commit into from
Closed

Correct <br /> Tags and set Title #813

wants to merge 1 commit into from

Conversation

Meistercoach83
Copy link
Contributor

No description provided.

@lirantal
Copy link
Member

LGTM

@lirantal lirantal added this to the 0.4.x milestone Aug 16, 2015
@lirantal lirantal self-assigned this Aug 16, 2015
@lirantal
Copy link
Member

Indentation should be 2 spaces

@rhutchison
Copy link
Contributor

@Meistercoach83 Why do we need to correct
tags to be compatible with XHTML?
is sufficient.

@lirantal
Copy link
Member

@rhutchison you're right, it shouldn't really matter because it's only relevant for XHTML but this template is for e-mails and not for browsers to maybe it's just safer to use XHTML notations for e-mail clients?

@ilanbiala
Copy link
Member

What's the difference between this and #814?

@lirantal
Copy link
Member

@ilanbiala look closely on the filename in the view - they are different email templates to be sent out.

@codydaig
Copy link
Member

@Meistercoach83 Can you put the indentation back to 2 spaces?

@ilanbiala
Copy link
Member

@lirantal @Meistercoach83 why don't we just have 1 PR for both files? It's the same situation.

@rhutchison
Copy link
Contributor

Can we get #813 and #814 in one PR

@rhutchison rhutchison mentioned this pull request Aug 20, 2015
15 tasks
@lirantal
Copy link
Member

@rhutchison you're right but we already have this here so whatever @Meistercoach83 decides, doesn't matter that much to me.

@Meistercoach83 please squash the commits to 1 and address the indentation issue to 2 spaces so we can merge this in.

@ilanbiala ilanbiala modified the milestones: 0.4.1, 0.4.x Aug 31, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants