Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Update package.json: devDependencies #935

Closed
wants to merge 1 commit into from
Closed

Update package.json: devDependencies #935

wants to merge 1 commit into from

Conversation

shayas
Copy link

@shayas shayas commented Sep 25, 2015

Update karma version to 0.13.10

Update karma version to 0.13.10
@ilanbiala
Copy link
Member

Breaking Changes

The public api interface has changed to a constructor form. To upgrade change javascript var server = require(‘karma’).server server.start(config, done) to javascript var Server = require(‘karma’).Server var server = new Server(config, done) server.start() Closes #1037, #1482, #1467 (82cbbadd)

@jloveland we may need to use this in Gulp to make sure the server is running before Karma is.

@mleanos
Copy link
Member

mleanos commented Sep 25, 2015

@ilanbiala Can you explain what the issue is here? Why do we need to update to this newer version of Karma?

I've been doing some work with Karma & Gulp, so I'm just trying to understand.

Also, we have this open PR #891

@ilanbiala
Copy link
Member

@mleanos just some bug fixes and deps updates.

@mleanos
Copy link
Member

mleanos commented Sep 25, 2015

@ilanbiala Thank you. I'll look into that, and test this newer version.

@ilanbiala
Copy link
Member

@mleanos did you ever run into any problems with the new version of karma? I don't think I had any issues, but it was a long time and I may have forgotten something.

@ilanbiala
Copy link
Member

@shayas can you also upgrade grunt-karma to 0.12.1 and remove gulp-karma and switch the implementation to the one found in https://github.com/karma-runner/gulp-karma?

@ilanbiala
Copy link
Member

Superseded by #1080.

@ilanbiala ilanbiala closed this Nov 30, 2015
@mleanos
Copy link
Member

mleanos commented Nov 30, 2015

@ilanbiala Thank you. And to answer your question about Karma. I didn't run into any problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants