Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quotes around user agent to allow spaces in it #427

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Add quotes around user agent to allow spaces in it #427

merged 1 commit into from
Mar 7, 2023

Conversation

leonardehrenfried
Copy link
Collaborator

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Mar 7, 2023

  • The user agent was changed from ${USER_AGENT} to "${USER_AGENT}"
  • This change is made in both 4.1 and 4.2 versions of the init script

@philipkozeny philipkozeny merged commit e949195 into master Mar 7, 2023
@philipkozeny philipkozeny deleted the user-agent branch March 7, 2023 14:44
@lonvia
Copy link

lonvia commented Mar 11, 2023

This is not doing what you thought it would do. You are now sending a user agent of "\x22mediagis/nominatim-docker:4.2.1\x22", i.e. with the quotes you added included.

@philipkozeny philipkozeny mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardehrenfried @lonvia @philipkozeny