Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.3 update & fix curl #444

Merged
merged 8 commits into from
Apr 18, 2023
Merged

Conversation

philipkozeny
Copy link
Collaborator

Besides the Nominatim update & curl fixes I have also set a custom user agent for our Github Actions so that those can be distinguished and fixed a bug in the Actions.

@what-the-diff
Copy link

what-the-diff bot commented Apr 18, 2023

PR Summary

  • User agent added to Docker run commands
    A user agent has been added to all Docker run commands, allowing for better identification and tracking of application usage in server logs.

  • Nominatim Version Updated
    The Nominatim version has been updated from 4.1.2 to 4.1.3 in the Dockerfile for the 'v4-latest' tag, improving the application's performance and reliability. A new tag, 'v4-previous,' has been added with the Nominatim version set to 4.1.2, providing an option to use the older version if needed.

@philipkozeny
Copy link
Collaborator Author

also fixes #427

@@ -1,11 +1,12 @@
#!/bin/bash -ex

OSMFILE=${PROJECT_DIR}/data.osm.pbf
CURL="curl -L -A \"${USER_AGENT}\" --fail-with-body"

CURL=("curl" "-L" "-A" "${USER_AGENT}" "--fail-with-body")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for figuring that out!

@philipkozeny philipkozeny merged commit 82c9080 into mediagis:master Apr 18, 2023
@philipkozeny philipkozeny deleted the 4.2.2-update branch April 18, 2023 10:16
@leonardehrenfried
Copy link
Collaborator

Good work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants