Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Apdex score of contact_list #9006

Closed
Benmuiruri opened this issue Apr 12, 2024 · 1 comment · Fixed by #9007
Closed

Improve Apdex score of contact_list #9006

Benmuiruri opened this issue Apr 12, 2024 · 1 comment · Fixed by #9007
Assignees
Labels
Type: Performance Make something faster
Milestone

Comments

@Benmuiruri
Copy link
Contributor

Benmuiruri commented Apr 12, 2024

Describe the performance issue
Care Teams KR
Initial research done

In the first cycle of performance optimisation I did not find any glaring performance bottlenecks. In this issue I suggest two refactors that might improve performance or at least better maintainability that could lead to potentially improved performance.

contactsComponent

  1. In contacts-component.ts, the ngOnInit method mixes synchronous and asynchronous logic (code) which can be refactored to use async - await
  2. The initialization of the contacts Component can also be wrapped in a try - catch block to allow for centralized error handling instead of error handling in each promise.
  3. The subscription management (code) can also be refactored into a separate method. This wont particularly lead to a performance gain but it improves the separation of concerns.

searchService

In looking for ways to optimize the contact_list:query I reviewed the search library and there could be possible optimization by avoiding redundancy of responses.map

@Benmuiruri Benmuiruri added the Type: Performance Make something faster label Apr 12, 2024
@Benmuiruri Benmuiruri added this to the 4.7.0 milestone Apr 12, 2024
@Benmuiruri Benmuiruri self-assigned this Apr 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Care Teams Apr 12, 2024
@Benmuiruri Benmuiruri moved this from Backlog to In Progress in Care Teams Apr 12, 2024
@Benmuiruri Benmuiruri linked a pull request Apr 12, 2024 that will close this issue
5 tasks
@garethbowen garethbowen modified the milestones: 4.7.0, 4.8.0 Apr 26, 2024
@garethbowen
Copy link
Contributor

Moved to 4.8.0 so as not to hold up the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Performance Make something faster
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants