Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(#9006): reduce contacts page_size and refactor ngOnInit #9007

Merged
merged 8 commits into from
May 7, 2024
Merged

perf(#9006): reduce contacts page_size and refactor ngOnInit #9007

merged 8 commits into from
May 7, 2024

Conversation

Benmuiruri
Copy link
Contributor

@Benmuiruri Benmuiruri commented Apr 12, 2024 •
edited
Loading

Description

  • Refactor ngOnInit to use async/await and add a unified try/catch block

#9006

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@Benmuiruri Benmuiruri added this to the 4.7.0 milestone Apr 12, 2024
@Benmuiruri Benmuiruri force-pushed the 9006-improve-contact-list-apdex branch from f1f8cd5 to e5a2c12 Compare April 12, 2024 07:10
@Benmuiruri Benmuiruri linked an issue Apr 12, 2024 that may be closed by this pull request
Improve Apdex score of contact_list #9006
Closed
@Benmuiruri Benmuiruri requested a review from jkuester April 12, 2024 09:56
@Benmuiruri
Copy link
Contributor Author

Benmuiruri commented Apr 12, 2024 •
edited
Loading

HI @jkuester, 👋 I had attempted some magic 🪄 ....but I could not see any perf improvements, that's why I withdrew the review request as I do more digging ⛏️ .

@Benmuiruri Benmuiruri changed the title perf(#9006): refactor search lib and contactsComponent perf(#9006): refactor contactsComponent Apr 12, 2024
@Benmuiruri Benmuiruri removed the request for review from jkuester April 12, 2024 12:24
@Benmuiruri Benmuiruri force-pushed the 9006-improve-contact-list-apdex branch from f3ed747 to b663c46 Compare April 26, 2024 06:15
@Benmuiruri Benmuiruri marked this pull request as ready for review April 26, 2024 10:18
@garethbowen garethbowen removed this from the 4.7.0 milestone Apr 26, 2024
@Benmuiruri Benmuiruri mentioned this pull request Apr 27, 2024
Closed
@Benmuiruri Benmuiruri force-pushed the 9006-improve-contact-list-apdex branch from 986f0c8 to 19dd0ab Compare April 30, 2024 05:50
@Benmuiruri Benmuiruri requested a review from latin-panda May 3, 2024 07:48
@Benmuiruri Benmuiruri changed the title perf(#9006): refactor contactsComponent perf(#9006): reduce contacts page_size and refactor ngOnInit May 3, 2024
latin-panda
latin-panda approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@latin-panda latin-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did a quick test and runs fine

Please update your branch with the latest before merging.

@michaelkohn michaelkohn linked an issue May 6, 2024 that may be closed by this pull request
contact_list apdex: research and development cycle 3 medic/care-teams#104
Closed
@Benmuiruri Benmuiruri force-pushed the 9006-improve-contact-list-apdex branch from 19dd0ab to 872692a Compare May 7, 2024 10:55
@Benmuiruri Benmuiruri merged commit 4ced693 into master May 7, 2024
39 checks passed
@Benmuiruri Benmuiruri deleted the 9006-improve-contact-list-apdex branch May 7, 2024 12:14
@latin-panda latin-panda restored the 9006-improve-contact-list-apdex branch July 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latin-panda latin-panda latin-panda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

contact_list apdex: research and development cycle 3 Improve Apdex score of contact_list
3 participants
@Benmuiruri @latin-panda @garethbowen