Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change shipping price type #5824

Closed
Xxsource98 opened this issue Dec 7, 2023 · 2 comments · Fixed by #5895
Closed

Unable to change shipping price type #5824

Xxsource98 opened this issue Dec 7, 2023 · 2 comments · Fixed by #5895

Comments

@Xxsource98
Copy link

Bug report

I can not change Price Type in Shipping Option from "Flat Rate" to "Calculated".

Describe the bug

When I am trying to, I am getting notification with success message, but it is not updating. I have to recreate shipping option.

System information

Medusa version (including plugins): 1.18.0
Node.js version: 18.17.1
Database: postgresql
Operating system: ubuntu 20.04
Browser (if relevant): brave

@oliwerhelsen
Copy link

Please provide the payload for your request and also the error message that you have been given.

@Xxsource98
Copy link
Author

Hi, sorry for late answer. The problem is there is no any error on updating. It is like just not applying update in backend function. Even when I set "calculated" from "flat_rate" it is still sending "old" data of shipping option:

(When I wanted to change to "calculated" type on "test1" shipping option)
http://localhost:9000/admin/shipping-options/so_01HHCMHCYMYAF4SG32KAH1E80R
POST 200 OK
{"name":"test1","requirements":[],"admin_only":false,"amount":100,"metadata":{}}

@kodiakhq kodiakhq bot closed this as completed in #5895 Dec 15, 2023
kodiakhq bot pushed a commit that referenced this issue Dec 15, 2023
**What**
- allow updates to shipping option price type
- Clean up the use of strings in the api validation

Fixes #5824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants