Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Update shipping option price type #5895

Merged
merged 6 commits into from
Dec 15, 2023
Merged

feat(medusa): Update shipping option price type #5895

merged 6 commits into from
Dec 15, 2023

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Dec 15, 2023 •
edited
Loading

What

  • allow updates to shipping option price type
  • Clean up the use of strings in the api validation

Fixes #5824

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e74b21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pKorsholm pKorsholm changed the title Feat(medusa): Update shipping option price type feat(medusa): Update shipping option price type Dec 15, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 9:52am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 9:52am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2023 9:52am

@pKorsholm pKorsholm marked this pull request as ready for review December 15, 2023 07:17
@pKorsholm pKorsholm requested a review from a team as a code owner December 15, 2023 07:17
adrien2p
adrien2p approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few todos

packages/medusa/src/api/routes/admin/shipping-options/create-shipping-option.ts Outdated Show resolved Hide resolved
packages/medusa/src/services/shipping-option.ts Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 56b07ed into develop Dec 15, 2023
15 checks passed
@kodiakhq kodiakhq bot deleted the feat/update-shipping-option-price-type branch December 15, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p approved these changes

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to change shipping price type
3 participants
@pKorsholm @adrien2p @olivermrbl