Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(medusa): Legacy total service to accept custom items #3027

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

adrien2p
Copy link
Member

Followup pr of #3008

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: 62bdd87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adrien2p adrien2p force-pushed the fix/totals-service-custom-item branch from 506eda0 to 0487a16 Compare January 13, 2023 13:49
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olivermrbl
Copy link
Contributor

@adrien2p Anything missing before merging? It's still in draft

@olivermrbl olivermrbl marked this pull request as ready for review January 16, 2023 08:55
@olivermrbl olivermrbl requested a review from a team as a code owner January 16, 2023 08:55
@olivermrbl olivermrbl merged commit 8c08d00 into develop Jan 16, 2023
@olivermrbl olivermrbl deleted the fix/totals-service-custom-item branch January 16, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants